Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove label "Project is not eligible for QF Matching" during active QF rounds #4984

Open
1 task
laurenluz opened this issue Jan 28, 2025 · 5 comments
Open
1 task
Assignees
Labels
QF Quadratic Funding Related

Comments

@laurenluz
Copy link
Member

Last week, we had a QF round "active" but not yet passed the start time, and I noted we were showing that projects were "not eligible for QF matching". I think this label is a bit unnecessary (and it's especially strange to see when there IS no QF round open...), and we should just remove it all together.

AC

  • If there is an active QF round, and a project is not part of that round, there should be no label "Project is not eligible for QF matching" - just remove it and show only the labels corresponding to GIVbacks.

All other conditions work fine already on Giveth.

Image

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jan 28, 2025
@laurenluz laurenluz moved this from New Issues to Product Backlog in All-Devs Jan 28, 2025
@divine-comedian divine-comedian added the QF Quadratic Funding Related label Feb 10, 2025
@divine-comedian divine-comedian moved this from Product Backlog to Sprint Backlog in All-Devs Feb 10, 2025
@maryjaf
Copy link
Collaborator

maryjaf commented Feb 18, 2025

Can I work on this issue? @divine-comedian

@kkatusic
Copy link
Collaborator

Can I work on this issue? @divine-comedian

I give you permission, then you will open QF round that I need for other issue ;)

@divine-comedian
Copy link
Contributor

@maryjaf take it!

@maryjaf maryjaf moved this from Sprint Backlog to In Progress in All-Devs Feb 18, 2025
@maryjaf maryjaf moved this from In Progress to Code Review/PR in All-Devs Feb 19, 2025
@kkatusic kkatusic moved this from Code Review/PR to QA in All-Devs Feb 19, 2025
@divine-comedian
Copy link
Contributor

@LatifatAbdullahi this is ready for you to test

@LatifatAbdullahi
Copy link

Test Update

-If there is an active QF round, and a project is not part of that round, there should be no label "Project is not eligible for QF matching" - just remove it and show only the labels corresponding to GIVbacks. - Pass

Image

@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in All-Devs Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QF Quadratic Funding Related
Projects
Status: Done
Development

No branches or pull requests

5 participants