Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill/review contracts value in config #2

Open
aminlatifi opened this issue Jan 27, 2025 · 7 comments
Open

Fill/review contracts value in config #2

aminlatifi opened this issue Jan 27, 2025 · 7 comments
Assignees

Comments

@aminlatifi
Copy link
Member

It's super important to fill the giveconomy monitoring configuration with all and the latest values of related contracts.
I have entered values, so it's needed someone to review them.
Also, I am sure the bot section is not filled for every chain. I deliberately didn't fill them in to make this issue later and get other related guys involved in this project.

bots: [
{
name: 'GIVPower Bot',
address: '0x7ff3853f98497eb3fadbf83eb9756e18e476a40b',
},

To brief:

  1. Review all contract values
  2. Fill values

Note that the develop.ts and production.ts can be same. The only difference is that the production.ts will be used if NODE_ENV=production is set in .env. Also, the graphql schema would not fetch by API. Running in develop mode would be fine so.

@geleeroyale
Copy link
Contributor

hey @aminlatifi we need to pull someone in who has an overview of the giveconomy to review this

@aminlatifi
Copy link
Member Author

hey @aminlatifi we need to pull someone in who has an overview of the giveconomy to review this

I think bot sections can be managed by the devops team. Other values can be crossed checked with https://www.notion.so/giveth/Deployment-52935e6579034f1b940bbef161e82229?pvs=4

@geleeroyale
Copy link
Contributor

ok thanks I was looking for that.

@geleeroyale
Copy link
Contributor

Thank you @aminlatifi - I update https://github.com/Giveth/giveconomy-monitoring/blob/main/src/config/production.ts according to the Deployment page in Notion (no changes) and set the new address for givpower-bot (updated for all three chains to correct value) ... maybe someone can do another quick check, but it should be fine now

@laurenluz
Copy link
Member

@aminlatifi can you review? :)

@geleeroyale
Copy link
Contributor

Alert system is running now - looks good to me! I uncommented Gnosis and op configs, doublechecked against notion deployments and updated the bod address

@aminlatifi
Copy link
Member Author

Alert system is running now - looks good to me! I uncommented Gnosis and op configs, doublechecked against notion deployments and updated the bod address

@geleeroyale Two points:

  1. We can also support givpower unlock bots.
  2. The develop.ts holds production config right now. The only differences are, it will be activated when NODE_ENV is not set to production and in develop mode GraphQL introspection mode will be enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants