Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy upgraded contracts to staging & production #49

Open
laurenluz opened this issue Feb 12, 2025 · 5 comments
Open

Deploy upgraded contracts to staging & production #49

laurenluz opened this issue Feb 12, 2025 · 5 comments
Assignees

Comments

@laurenluz
Copy link
Member

@aminlatifi was suggesting that @divine-comedian should do this? can you guys discuss?

@divine-comedian
Copy link
Contributor

What is the additional context here @aminlatifi - what needs to be deployed and where?

@laurenluz
Copy link
Member Author

It's about this PR basically, that you reviewed @divine-comedian: #48 (comment)

@aminlatifi says we need to deploy it on staging, and then on production.. to fix/upgrade our unipool contracts.

@aminlatifi - can you help to provide more context? @divine-comedian may be able to help, but I think it is not clear what he should do.

@aminlatifi
Copy link
Member

It's about this PR basically, that you reviewed @divine-comedian: #48 (comment)

@aminlatifi says we need to deploy it on staging, and then on production.. to fix/upgrade our unipool contracts.

@aminlatifi - can you help to provide more context? @divine-comedian may be able to help, but I think it is not clear what he should do.

The task is deploying new implementations of GIVpower (GIVpower.sol and UnipoolGIVpower.sol) and then upgrade corresponding contracts to replace the their implementations to these new ones. Just note, the staging and production env have different values in basic parameters like duration, start time, etc.

@divine-comedian
Copy link
Contributor

divine-comedian commented Feb 17, 2025

@aminlatifi can you confirm which is the correct INITIAL_DATE for which chains?

I can see a few different varities and it's not clear what is the correct one.

for example:

  • gnosis staging - 1640617800
  • gnosis production - 1640707200
  • optimism mainnet - 1654012800
  • optimism staging - 1654415235
  • zkevm cardona - 1654012800
  • zkevm main - 1654012800

are these correct? Should I reuse the current values for deploying the new ones?

duration and max rounds appear to be the same across staging and production networks - can you be more specific as to what other variables need to be different?

@aminlatifi
Copy link
Member

@aminlatifi can you confirm which is the correct INITIAL_DATE for which chains?

I can see a few different varities and it's not clear what is the correct one.

for example:

  • gnosis staging - 1640617800
  • gnosis production - 1640707200
  • optimism mainnet - 1654012800
  • optimism staging - 1654415235
  • zkevm cardona - 1654012800
  • zkevm main - 1654012800

are these correct? Should I reuse the current values for deploying the new ones?

duration and max rounds appear to be the same across staging and production networks - can you be more specific as to what other variables need to be different?

Basically, the INITIAL_DATE must align with givback rounds. For gnosis production, it's givback 1st round start time. Optimism and zkevm ones have givback round 12th start time in their INITIAL_DATE.

For staging, we didn't observe this rule unfortunately, so you can put the values as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants