-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy upgraded contracts to staging & production #49
Comments
What is the additional context here @aminlatifi - what needs to be deployed and where? |
It's about this PR basically, that you reviewed @divine-comedian: #48 (comment) @aminlatifi says we need to deploy it on staging, and then on production.. to fix/upgrade our unipool contracts. @aminlatifi - can you help to provide more context? @divine-comedian may be able to help, but I think it is not clear what he should do. |
The task is deploying new implementations of GIVpower (GIVpower.sol and UnipoolGIVpower.sol) and then upgrade corresponding contracts to replace the their implementations to these new ones. Just note, the staging and production env have different values in basic parameters like duration, start time, etc. |
@aminlatifi can you confirm which is the correct I can see a few different varities and it's not clear what is the correct one. for example:
are these correct? Should I reuse the current values for deploying the new ones? duration and max rounds appear to be the same across staging and production networks - can you be more specific as to what other variables need to be different? |
Basically, the For staging, we didn't observe this rule unfortunately, so you can put the values as they are. |
@aminlatifi was suggesting that @divine-comedian should do this? can you guys discuss?
The text was updated successfully, but these errors were encountered: