fix: make is_executable() more permissive by taking the group and 'other' permissions into account.

Byron · Byron · commit db44c6e7db96 · 2025-04-15T13:05:12.000+02:00
diff --git a/gix-fs/src/lib.rs b/gix-fs/src/lib.rs
@@ -77,10 +77,10 @@ pub struct Stack {
 }
 
 #[cfg(unix)]
-/// Returns whether a a file has the executable permission set.
+/// Returns whether a file has the executable permission set.
 pub fn is_executable(metadata: &std::fs::Metadata) -> bool {
     use std::os::unix::fs::MetadataExt;
-    (metadata.mode() & 0o100) != 0
+    (metadata.mode() & 0o111) != 0
 }
 
 /// Classifiers for IO-errors.

Original file line number	Diff line number	Diff line change
`@@ -77,10 +77,10 @@ pub struct Stack {`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`#[cfg(unix)]`
`80`		`-/// Returns whether a a file has the executable permission set.`
	`80`	`+/// Returns whether a file has the executable permission set.`
`81`	`81`	`pub fn is_executable(metadata: &std::fs::Metadata) -> bool {`
`82`	`82`	`use std::os::unix::fs::MetadataExt;`
`83`		`- (metadata.mode() & 0o100) != 0`
	`83`	`+ (metadata.mode() & 0o111) != 0`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`/// Classifiers for IO-errors.`