fix: don't pass 'include-tag' as argument by default.

This flag always has to be added by the caller based on configuration.

Author: Byron

git-protocol/src/command/mod.rs

@@ -94,7 +94,7 @@ mod with_io {
         /// Only useful for V2
         pub(crate) fn initial_arguments(&self, features: &[Feature]) -> Vec<BString> {
             match self {
-                Command::Fetch => ["thin-pack", "include-tag", "ofs-delta"]
+                Command::Fetch => ["thin-pack", "ofs-delta"]
                     .iter()
                     .map(|s| s.as_bytes().as_bstr().to_owned())
                     .chain(

git-protocol/src/command/tests.rs

@@ -88,7 +88,7 @@ mod v2 {
                         git_transport::Protocol::V2,
                         &capabilities("fetch", "shallow filter sideband-all packfile-uris")
                     )),
-                    ["thin-pack", "include-tag", "ofs-delta", "sideband-all"]
+                    ["thin-pack", "ofs-delta", "sideband-all"]
                         .iter()
                         .map(|s| s.as_bytes().as_bstr().to_owned())
                         .collect::<Vec<_>>(),

git-protocol/src/fetch/tests.rs

@@ -260,7 +260,6 @@ mod arguments {
                 out.as_bstr(),
                 b"0012command=fetch
 0001000ethin-pack
-0010include-tag
 000eofs-delta
 000ddeepen 1
 0014deepen-relative
@@ -294,7 +293,6 @@ mod arguments {
                     out.as_bstr(),
                     b"0012command=fetch
 0001000ethin-pack
-0010include-tag
 000eofs-delta
 000ddeepen 1
 0017deepen-since 12345
@@ -304,7 +302,6 @@ mod arguments {
 0032have 0000000000000000000000000000000000000000
 00000012command=fetch
 0001000ethin-pack
-0010include-tag
 000eofs-delta
 000ddeepen 1
 0017deepen-since 12345
@@ -332,7 +329,6 @@ mod arguments {
                 out.as_bstr(),
                 b"0012command=fetch
 0001000ethin-pack
-0010include-tag
 000eofs-delta
 001dwant-ref refs/heads/main
 0009done

git-protocol/src/handshake/mod.rs

@@ -16,7 +16,7 @@ pub enum Ref {
     },
     /// A ref pointing to a commit object
     Direct {
-        /// The name at which the ref is located, like `refs/heads/main`.
+        /// The name at which the ref is located, like `refs/heads/main` or `refs/tags/v1.0` for lightweight tags.
         full_ref_name: BString,
         /// The hash of the object the ref points to.
         object: git_hash::ObjectId,

git-protocol/tests/fetch/v2.rs

@@ -185,7 +185,6 @@ async fn ref_in_want() -> crate::Result {
             "002fgit-upload-pack does/not/matter\0\0version=2\00012command=fetch
 0014agent={}
 0001000ethin-pack
-0010include-tag
 000eofs-delta
 001dwant-ref refs/heads/main
 0009done