Skip to content

Commit 73dcf57

Browse files
committed
Remove test-cross CI job definition
One or both of these matrix jobs, or related ones, be brought back some day, probably to run only specific tests that have failed in the past and started passing. The files for local testing with `cross` (and associated `justfile` recipes) are kept.
1 parent 803d054 commit 73dcf57

File tree

1 file changed

+0
-37
lines changed

1 file changed

+0
-37
lines changed

.github/workflows/ci.yml

-37
Original file line numberDiff line numberDiff line change
@@ -327,42 +327,6 @@ jobs:
327327
- name: Test (nextest)
328328
run: cargo nextest run --target $env:TARGET --workspace --no-fail-fast size
329329

330-
# FIXME: *If* this is kept, then remove `fail-fast: false`, run only a subset of the tests unless
331-
# building and running the whole test suite is fast, and add a `Swatinem/rust-cache` step.
332-
test-cross:
333-
runs-on: ubuntu-latest
334-
335-
strategy:
336-
matrix:
337-
nickname: [ android, s390x ]
338-
include:
339-
- nickname: android
340-
target: armv7-linux-androideabi
341-
- nickname: s390x
342-
target: s390x-unknown-linux-gnu
343-
fail-fast: false
344-
345-
steps:
346-
- uses: actions/checkout@v4
347-
- name: Install Rust
348-
uses: dtolnay/rust-toolchain@master
349-
with:
350-
toolchain: stable
351-
targets: ${{ matrix.target }}
352-
- uses: extractions/setup-just@v3
353-
- name: Install cross
354-
uses: taiki-e/install-action@v2
355-
with:
356-
tool: cross
357-
- name: Configure binfmt_misc for QEMU
358-
run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
359-
- name: Build cross image
360-
run: just cross-image ${{ matrix.target }}
361-
- name: Test (unit)
362-
env:
363-
RUST_BACKTRACE: '1'
364-
run: just cross-test-${{ matrix.nickname }}
365-
366330
lint:
367331
runs-on: ubuntu-latest
368332

@@ -520,7 +484,6 @@ jobs:
520484
env:
521485
# List all jobs that are intended NOT to block PR auto-merge here.
522486
EXPECTED_NONBLOCKING_JOBS: |-
523-
test-cross
524487
cargo-deny-advisories
525488
wasm
526489
tests-pass

0 commit comments

Comments
 (0)