Fixed bug where projarg parameters in the style of /target: would be parsed as names not values.

Sebastian Nemeth · Sebastian Nemeth · commit b67733532953 · 2015-03-31T15:57:10.000+03:00
diff --git a/GitVersionExe/ArgumentParser.cs b/GitVersionExe/ArgumentParser.cs
@@ -5,8 +5,9 @@ namespace GitVersion
     using System.Collections.Specialized;
     using System.Linq;
     using System.Reflection;
+    using System.Text.RegularExpressions;
+
 
- 
     public class ArgumentParser
     {
         static ArgumentParser()
@@ -259,7 +260,8 @@ static NameValueCollection CollectSwitchesAndValuesFromArguments(List<string> na
 
         static bool IsSwitchArgument(string value)
         {
-            return value != null && (value.StartsWith("-") || value.StartsWith("/")) && !value.StartsWith("/p:"); //Exclude msbuild parameters, which should be parsed as values, not switch names.
+            return value != null && (value.StartsWith("-") || value.StartsWith("/")) 
+                && !Regex.Match(value, @"/\w+:").Success; //Exclude msbuild & project parameters in form /blah:, which should be parsed as values, not switch names.
         }
 
         static bool IsSwitch(string switchName, string value)

Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,9 @@ namespace GitVersion`
`5`	`5`	`using System.Collections.Specialized;`
`6`	`6`	`using System.Linq;`
`7`	`7`	`using System.Reflection;`
	`8`	`+ using System.Text.RegularExpressions;`
	`9`	`+`
`8`	`10`
`9`		`-`
`10`	`11`	`public class ArgumentParser`
`11`	`12`	`{`
`12`	`13`	`static ArgumentParser()`
`@@ -259,7 +260,8 @@ static NameValueCollection CollectSwitchesAndValuesFromArguments(List<string> na`
`259`	`260`
`260`	`261`	`static bool IsSwitchArgument(string value)`
`261`	`262`	`{`
`262`		`- return value != null && (value.StartsWith("-") \|\| value.StartsWith("/")) && !value.StartsWith("/p:"); //Exclude msbuild parameters, which should be parsed as values, not switch names.`
	`263`	`+ return value != null && (value.StartsWith("-") \|\| value.StartsWith("/"))`
	`264`	`+ && !Regex.Match(value, @"/\w+:").Success; //Exclude msbuild & project parameters in form /blah:, which should be parsed as values, not switch names.`
`263`	`265`	`}`
`264`	`266`
`265`	`267`	`static bool IsSwitch(string switchName, string value)`