Skip to content

Improvements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lopestom opened this issue Feb 16, 2025 · 7 comments
Closed

Improvements #2

lopestom opened this issue Feb 16, 2025 · 7 comments

Comments

@lopestom
Copy link
Contributor

I think your project is very good.

I'm adding some parts that will automatically complement the actions with the desired permission. In addition, some parts for the trustkernel encryption/decryption mode.

To this end, I'm also testing each change/inclusion.

As soon as I achieve the goal, I'll fork your project and ask for PR.

Before I do anything stupid with scrypt, do you have any "doubts" about the changes?

@GitFASTBOOT
Copy link
Owner

I think your project is very good.

I'm adding some parts that will automatically complement the actions with the desired permission. In addition, some parts for the trustkernel encryption/decryption mode.

To this end, I'm also testing each change/inclusion.

As soon as I achieve the goal, I'll fork your project and ask for PR.

Before I do anything stupid with scrypt, do you have any "doubts" about the changes?

No I don't mind for changes you can send pr after testing it

@lopestom
Copy link
Contributor Author

No I don't mind for changes you can send pr after testing it

Do you can open a new branch called test please?

Tks

@GitFASTBOOT
Copy link
Owner

No I don't mind for changes you can send pr after testing it

Do you can open a new branch called test please?

Tks

I will now

@lopestom
Copy link
Contributor Author

lopestom commented Feb 19, 2025

I will now

The tests were completed successfully. Clearly not all files will be needed, other more specific files may be missing, but the main purpose is the speed and quantity of files that the user will have.

I believe you should review the script for some improvement changes and code cleanup.

When you can so Close this "issue" please.

@lopestom lopestom reopened this Feb 19, 2025
@GitFASTBOOT
Copy link
Owner

I will now

The tests were completed successfully. Clearly not all files will be needed, other more specific files may be missing, but the main purpose is the speed and quantity of files that the user will have.

I believe you should review the script for some improvement changes and code cleanup.

When you can so Close this "issue" please.

Thanks man

@GitFASTBOOT
Copy link
Owner

GitFASTBOOT commented Feb 19, 2025

@lopestom can you send pull request again I removed the test branch by wrong or join repo as I see your script need to modify it a bit

@lopestom
Copy link
Contributor Author

@lopestom can you send pull request again I removed the test branch by wrong or join repo as I see your script need to modify it a bit

Done again.

@lopestom lopestom reopened this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants