Different Attachment Types within one Message cause invalid rendering (Compose UI)

[jnischler]

Describe the bug
Having multible different attachments within one message are displayed invalid.
The first matched attachment factory needs to render all attachments also not matched attachments.

SDK version

• 6.2.3

To Reproduce
Steps to reproduce the behavior:

1. Register at least 2 different attachmentFactories
2. add 2 different attachments to your message
3. post the message
4. See error

Expected behavior
Only matched attachments should be rendered by the corresponding attachment factory.

Regards
Julian

[jnischler]

stream-chat-android/stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/content/MessageAttachmentsContent.kt

Line 55 in 105ba6e

ChatTheme.attachmentFactories.firstOrNull { it.canHandle(attachments) }

At this position you are only checking for the first possible handler so if there is a file in the attachments the file handler will kick in but the media handler cant handle.
This should be changed to a per attachment basis oder you need to group the attachments by type this would make the most sense here.

[jnischler]

bump

[jnischler]

any news on this ?
this should be fixed!

[kanat]

Hi @jnischler,

Thank you very much for bringing this to our attention and for the detailed explanation.
It seems that this might be more in line with a feature request rather than an issue.

We appreciate your valuable input and are always keen to improve the product based on user feedback.

[andremion]

Hi @jnischler ,
Can you please double-check if this still happens in the latest release?
Thanks

[jnischler]

Hi @jnischler , Can you please double-check if this still happens in the latest release? Thanks

Hi,
Thanks for the update, we will check the issue asap.

@dduda88 could you have a look at this ?

regards
Julian