Skip to content

Commit c056bc2

Browse files
authored
PHP 8.4 compatibility (#22)
1 parent 4a411d2 commit c056bc2

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

.circleci/config.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ jobs:
141141
tag: << parameters.version >>
142142
parameters:
143143
version:
144-
default: "8.3"
144+
default: "8.4"
145145
description: The `cimg/php` Docker image version tag.
146146
type: string
147147
install-flags:
@@ -154,7 +154,7 @@ jobs:
154154
- when:
155155
condition:
156156
and:
157-
- equal: [ "8.3", <<parameters.version>> ]
157+
- equal: [ "8.4", <<parameters.version>> ]
158158
- equal: [ "", <<parameters.install-flags>> ]
159159
steps:
160160
- run-phpunit-tests:
@@ -164,7 +164,7 @@ jobs:
164164
condition:
165165
not:
166166
and:
167-
- equal: [ "8.3", <<parameters.version>> ]
167+
- equal: [ "8.4", <<parameters.version>> ]
168168
- equal: [ "", <<parameters.install-flags>> ]
169169
steps:
170170
- run-phpunit-tests:
@@ -176,5 +176,5 @@ workflows:
176176
- matrix-conditions:
177177
matrix:
178178
parameters:
179-
version: ["8.3", "8.2", "8.1", "8.0", "7.4"]
179+
version: ["8.4", "8.3", "8.2", "8.1", "8.0", "7.4"]
180180
install-flags: ["", "--prefer-lowest"]

composer.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
"fmizzell/maquina": "^1.1.1"
1616
},
1717
"require-dev": {
18-
"phpunit/phpunit": "^9.6",
19-
"rector/rector": "^0.15.17",
18+
"phpunit/phpunit": "^9.6.22",
19+
"rector/rector": "^2.0.0",
2020
"squizlabs/php_codesniffer": "^3.7",
21-
"symfony/phpunit-bridge": "^7.0"
21+
"symfony/phpunit-bridge": "^7.2"
2222
},
2323
"autoload": {
2424
"psr-4": {

src/Parser/Csv.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ class Csv implements ParserInterface, \JsonSerializable
1313
private $escape;
1414
private array $recordEnd;
1515

16-
private $records;
17-
private $fields;
16+
private array $records;
17+
private array $fields;
1818
private string $field;
1919

2020
/**
@@ -117,7 +117,7 @@ public function finish(): void
117117
}
118118
}
119119

120-
private function getCharType(string $char)
120+
private function getCharType(string $char): string
121121
{
122122
$type = sm::CHAR_TYPE_OTHER;
123123
if (in_array($char, $this->recordEnd)) {

0 commit comments

Comments
 (0)