Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup parallel structures code #84

Open
stoiver opened this issue Nov 21, 2015 · 1 comment
Open

Cleanup parallel structures code #84

stoiver opened this issue Nov 21, 2015 · 1 comment

Comments

@stoiver
Copy link
Member

stoiver commented Nov 21, 2015

Should combine sequential and parallel structures code. There is replication of code which should be removed. I suggest moving most of the code to the structures directory, and make sure the code can run both sequential and parallel mode.

With such a cleanup it should be easy to add new structures.

@gareth-d-ga
Copy link
Contributor

With this, it is worth considering whether to follow the approach of anuga.structures.internal_boundary_operator which allows a general stage/discharge function.

If that approach is followed, we might need to further enhance the treatment of momentum transport. Although internal_boundary_operator permits an arbitrary stage-discharge function, the outflowing momentum is treated more crudely. The latter does matter, since the outflowing momentum will influence the downstream stage, which in turn influences the discharge.

I seem to recall the 'internal_boundary_operator' passes the full momentum from upstream to downstream by default, with some other options (??). We might need more sophisticated treatments for structures which curve internally or have large momentum loss.

stoiver referenced this issue in anuga-community/anuga_core Jul 25, 2023
latest Cython version treats Python3 as adefault language_str
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants