Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault: Not setting BC is possible, set a default #17

Open
stoiver opened this issue May 5, 2015 · 1 comment
Open

Fault: Not setting BC is possible, set a default #17

stoiver opened this issue May 5, 2015 · 1 comment

Comments

@stoiver
Copy link
Member

stoiver commented May 5, 2015

May set default as reflective or None. But what to do if None?

@stoiver stoiver added the bug label May 5, 2015
@stoiver stoiver added this to the 2.1 milestone Jun 4, 2015
@stoiver
Copy link
Member Author

stoiver commented Sep 3, 2015

Not sure this is a fault!

If set_boundary is not called then an error is raised in evolve loop stating that boundary conditions need to be set.

If not all the boundaries are set when using set_boundary, then an error is raised which is probably ok.

Maybe we could add a default_BC argument to set_boundary.

@stoiver stoiver added enhancement and removed bug labels Sep 3, 2015
@stoiver stoiver removed this from the 2.1 milestone Sep 3, 2015
stoiver added a commit that referenced this issue Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant