fix(social): avoid writing the file twice

Author: Geobert

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "emile"
-version = "0.5.2"
+version = "0.5.3"
 authors = ["Geobert Quach <[email protected]>"]
 edition = "2021"
 

Cargo.toml

@@ -53,11 +53,22 @@ pub async fn publish_post(post: &Path, cfg: &SiteConfig) -> Result<String> {
         );
     }
 
-    fs::write(&dest, &new_content)?;
-    fs::remove_file(&post)?;
-
     if let Some(social_cfg) = cfg.social.as_ref() {
-        push_to_social(social_cfg, &new_content, &dest).await?;
+        match push_to_social(social_cfg, &new_content, &dest).await {
+            Ok(new_content) => {
+                fs::write(&dest, &new_content)?;
+                fs::remove_file(&post)?;
+            }
+            Err(e) => {
+                // write the post even if social media failed
+                fs::write(&dest, &new_content)?;
+                fs::remove_file(&post)?;
+                return Err(e);
+            }
+        }
+    } else {
+        fs::write(&dest, &new_content)?;
+        fs::remove_file(&post)?;
     }
 
     Ok(dest.to_string_lossy().to_string())

src/publish.rs

@@ -10,7 +10,7 @@ use std::{
 use anyhow::{anyhow, bail, Result};
 use reqwest::Url;
 use serde_derive::Deserialize;
-use tracing::error;
+use tracing::{error, info};
 
 use crate::{
     config::{SocialApi, SocialCfg},
@@ -239,7 +239,7 @@ fn create_toot_link(
     Ok(tpl.replace("{links}", links))
 }
 
-pub async fn push_to_social(cfg: &SocialCfg, content: &str, dest: &Path) -> Result<()> {
+pub async fn push_to_social(cfg: &SocialCfg, content: &str, dest: &Path) -> Result<String> {
     if cfg.instances.is_empty() {
         bail!("No social servers defined.");
     }
@@ -270,11 +270,12 @@ pub async fn push_to_social(cfg: &SocialCfg, content: &str, dest: &Path) -> Resu
             acc
         });
 
+    info!("Inject social links: {links:?}");
+
     let new_content = content.replace(
         &cfg.link_tag,
         &create_toot_link(&templates_dir, cfg, &language, &links)?,
     );
-    std::fs::write(dest, new_content)?;
 
-    Ok(())
+    Ok(new_content)
 }