Skip to content

GMTInvalidInput error for basemap #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willschlitzer opened this issue Dec 14, 2020 · 1 comment · Fixed by #729
Closed

GMTInvalidInput error for basemap #730

willschlitzer opened this issue Dec 14, 2020 · 1 comment · Fixed by #729
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@willschlitzer
Copy link
Contributor

willschlitzer commented Dec 14, 2020

There is an if statement under basemap in base_plotting.py to raise an exception if B, L, or T aren't included in kwargs. The aliases for basemap do not include T, so that requirement cannot be completed. In #729 I removed "T in kwargs" from the if statement and changed the text of the exception to display the PyGMT parameter names.

It looks like the T parameter on the GMT docs is in reference to adding a compass or rose to the figure; I can add Tm and Td to the list of kwargs to check for if that is the case.

@welcome
Copy link

welcome bot commented Dec 14, 2020

👋 Thanks for opening your first issue here! Please make sure you filled out the template with as much detail as possible. You might also want to take a look at our contributing guidelines and code of conduct.

@seisman seisman added the documentation Improvements or additions to documentation label Dec 14, 2020
@seisman seisman linked a pull request Dec 15, 2020 that will close this issue
@seisman seisman closed this as completed Dec 15, 2020
@seisman seisman added this to the 0.3.0 milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants