Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return_call extension #60

Merged
merged 5 commits into from
Oct 24, 2024
Merged

return_call extension #60

merged 5 commits into from
Oct 24, 2024

Conversation

butterunderflow
Copy link
Contributor

@butterunderflow butterunderflow marked this pull request as ready for review October 23, 2024 11:52
@Kraks
Copy link
Member

Kraks commented Oct 23, 2024

Overall it looks great! But it seems sum.wat has not used the return_call instruction?

@butterunderflow
Copy link
Contributor Author

Overall it looks great! But it seems sum.wat has not used the return_call instruction?

Oh, that's true. I was using call to verify the correctness temporarily, but I forgot to put return_call back.

@butterunderflow butterunderflow merged commit d636e17 into main Oct 24, 2024
1 check passed
@Kraks Kraks deleted the zdh/return-call branch November 4, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butterunderflow @Kraks