Supporting export #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kraks
reviewed
Oct 14, 2024
Kraks
reviewed
Oct 14, 2024
|
Thanks for the PR -- looks good to me! Just added some minor comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the main function is specified by the function name given by export. This makes comparing with other wasm runtimes easier. (other wasm runtimes often default
(export "main" (func ...))to be the entry point).This also makes testing easier since we can just write an exported function, and the unlabel the entire file.
Note that
exportcan only take in numbers for now, which is the same asstart.I also edited
gen-wat-parser.sha bit since OSX sed is a bit different.PS: My formatter also formatted on
MiniWasm.scala