Block can take inputs #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butterunderflow
force-pushed
the
zdh/inputed_control
branch
2 times, most recently
from
a1caf0f to
24d3070
Compare
butterunderflow
commented
Oct 13, 2024
butterunderflow
force-pushed
the
zdh/inputed_control
branch
from
d9c6a13 to
9cc5940
Compare
Kraks
reviewed
Oct 17, 2024
|
Looks good to me, feel free to squash/merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our handling of block instruction somewhat rough and does not properly manage inputs, which does not align with the spec. Should we also support that behavior? There is already a
TODOin the code for that.