Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6.37 draws stack sizes over 99 twice #537

Open
ThexXTURBOXx opened this issue Sep 22, 2024 · 5 comments
Open

2.6.37 draws stack sizes over 99 twice #537

ThexXTURBOXx opened this issue Sep 22, 2024 · 5 comments

Comments

@ThexXTURBOXx
Copy link

ThexXTURBOXx commented Sep 22, 2024

Due to a bug in #528, stack sizes of 100 and higher are now rendered twice, as seen in the screenshot below (illustrated through items from an AE2 network).
The bug ocurrs starting in 2.6.37-pre and was not present in 2.6.36.

2024-09-22_11 23 59

Edit: I am using NEI-GTNH in Agrarian Skies 2.

@kend1e
Copy link

kend1e commented Jan 22, 2025

I think this is due to changing the render scale of large stacks in GuiContainerManager in the drawItem method. This should work fine, but for some reason it doesn't disable the original renderer

                if (itemstack.stackSize > 1) {
                    stackSize = ReadableNumberConverter.INSTANCE.toWideReadableForm(itemstack.stackSize);

                    if (stackSize.length() == 3) {
                        scale = 0.8f;
                    } else if (stackSize.length() == 4) {
                        scale = 0.6f;
                    } else if (stackSize.length() > 4) {
                        scale = 0.5f;
                    }

                } else {
                    stackSize = "";
                }
            }

@LegendSound
Copy link

LegendSound commented Feb 15, 2025

I have the same problem here in 2.7.29.
It would be great if there was an option to disable this feature or just fix this for AE2...

@slprime
Copy link
Member

slprime commented Feb 15, 2025

I have the same problem here in 2.7.29. It would be great if there was an option to disable this feature or just fix this for AE2...

  1. you see it in GTNH, or in another modpack?
  2. what ME you use?

P.S. NEI always draw this numbers. only dynamic size added
P.S.2. Most likely this is a feature of the terminal, and need fix ME

@ThexXTURBOXx
Copy link
Author

Most likely this is a feature of the terminal, and need fix ME

@slprime It is very unlikely that this is an issue with AE2. It worked fine in NEI <= 2.6.36. So, this issue has been introduced in 2.6.37-pre. If it is an issue with AE2, then it has always been present, but nobody noticed it - which would be a far fetch...

@slprime
Copy link
Member

slprime commented Feb 16, 2025

Most likely this is a feature of the terminal, and need fix ME

@slprime It is very unlikely that this is an issue with AE2. It worked fine in NEI <= 2.6.36. So, this issue has been introduced in 2.6.37-pre. If it is an issue with AE2, then it has always been present, but nobody noticed it - which would be a far fetch...

NEI <= 2.6.36 - always draw stackSize in default size. you dont see that ME draw it twice because size mathes
in 2.6.37-pre - nei start drawing stackSize dynamically, but МЕ stil draw it in default size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants