Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocketdyne engine not initializing immediately at world load can cause explosion #17016

Open
2 of 3 tasks
nullmana opened this issue Aug 15, 2024 · 2 comments
Open
2 of 3 tasks
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed

Comments

@nullmana
Copy link

Your GTNH Discord Username

No response

Your Pack Version

2.6.1

Your Server

SP

Java Version

Java 17

Type of Server

None

Your Expectation

Rocketdyne engine being fed fuel by a fluid regulator at a consistent rate should consume fuel consistently

The Reality

When loading into the world, the engine may skip one or more seconds of fuel consumption before initializing, resulting in consuming several seconds of fuel all at once, which can cause an explosion if the resulting energy output is greater than what the dynamo hatch provides

Example: Feed 250/sec purple rocket fuel with boost for ~128,000 EU/t with a 16A IV dynamo. While the game is running, this is perfectly safe. If the game is reloaded, this can cause an explosion.

Your Proposal

Void the first tick of fuel if the engine is running when the world is loaded, or do not make the engine explode from overvolting when the multiblock is this unstable.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@nullmana nullmana added Status: Triage Issue awaiting triage. Remove once this issue is processed Bug: Minor labels Aug 15, 2024
@Reflex18
Copy link
Contributor

While completely unrelated to your issue. You should feed the rocket dyne per tick rather then per second. This is because the rocket dyne consumes fuel every second tick for a 50% boost to efficacy. So making sure the regulator is set to per tick rather then per second is a nice boost to effiency.

@michaeldoylecs
Copy link

michaeldoylecs commented Aug 19, 2024

This applies to the Universal Chemical Fuel Engine as well. (At least on 2.6)

EDIT: I've been made aware that this should be fixed for UCFE on nightly.
GTNewHorizons/GoodGenerator#256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed
Projects
None yet
Development

No branches or pull requests

3 participants