Skip to content
This repository has been archived by the owner on Aug 24, 2019. It is now read-only.

Refactor GDGUkraine.errors module #112

Open
5 tasks
anxolerd opened this issue Aug 19, 2016 · 2 comments
Open
5 tasks

Refactor GDGUkraine.errors module #112

anxolerd opened this issue Aug 19, 2016 · 2 comments

Comments

@anxolerd
Copy link
Contributor

anxolerd commented Aug 19, 2016

Problem

Piece of code in errors.py (https://github.com/GDG-Ukraine/gdg.org.ua/blob/master/src/GDGUkraine/errors.py#L92-L199) was copy-pasted from cherrypy source and uses private methods, and modules of cherrypy.

This mean that any CherryPy update may break this code.

Proposal

To avoid breaks this code should be reconsidered and refactored without relying on private methods of anything

TODO

  • Drop copy-pasted magical code
  • Refactor getting error page.

TODO №2

copy-pasted from #66

@webknjaz
Copy link
Member

I like your point, as I recall I did this to close some feature immediately. This should be fixed for sure :)

@webknjaz webknjaz added this to the well-tested milestone Aug 20, 2016
@webknjaz webknjaz changed the title Dangerous copy-pasted code Refactor GDGUkraine.errors module Aug 25, 2016
@anxolerd anxolerd mentioned this issue Aug 27, 2016
3 tasks
@webknjaz
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants