Skip to content

Commit a56fce4

Browse files
committed
Working
1 parent 5d312dd commit a56fce4

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

src/main/java/io/fusionauth/http/io/ChunkedInputStream.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ private int processChunk(byte[] destination, int offset, int length) throws IOEx
162162
continue;
163163
}
164164

165-
// TODO : If we wanted to handle more than one chunk at a time, I think we would potentially continue here
165+
// TODO : Daniel : If we wanted to handle more than one chunk at a time, I think we would potentially continue here
166166
// and see if we can get more than one chunk completed before copying back to the destination.
167167
// Discuss with Brian.
168168
// Should we try this right now, or is this ok? Load testing with a small body,

src/main/java/io/fusionauth/http/server/internal/HTTPWorker.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,6 @@ private void closeSocketOnError(HTTPResponse response, int status) {
291291
logger.debug(String.format("[%s] Could not close the HTTP response.", Thread.currentThread().threadId()), e);
292292
} finally {
293293
// It is plausible that calling response.close() could throw an exception. We must ensure we close the socket.
294-
// TODO : Daniel : Review : Can I write a test to force this condition?
295294
closeSocketOnly(CloseSocketReason.Unexpected);
296295
}
297296
}

src/test/java/io/fusionauth/http/CoreTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public void badPreambleButReset() throws Exception {
116116
try (var client = HttpClient.newHttpClient(); var ignore = makeServer("http", handler, instrumenter).start()) {
117117
// Invalid request, missing Host header
118118
// - This should cause the socket to be reset
119-
// TODO : If we return a 400 since this is a client error and not a server error we are not currently resetting the request.
119+
// TODO : Daniel : Review : If we return a 400 since this is a client error and not a server error we are not currently resetting the request.
120120
// Do we need to?
121121
// Discuss with Brian?
122122
sendBadRequest("""
@@ -749,7 +749,7 @@ public void serverTimeout() throws Exception {
749749
println("Closed");
750750
};
751751

752-
// TODO : Daniel Review : what are we trying to test here, this test isn't doing what we think.
752+
// TODO : Daniel : Review : what are we trying to test here, this test isn't doing what we think.
753753
// It seems we are writing to the server as a client, and the server is slow to write back.
754754
// But this would be a client timeout and not a server timeout?
755755
// Seems like we should use withProcessingTimeoutDuration instead of withInitialReadTimeout?

0 commit comments

Comments
 (0)