Skip to content

Commit 48bf733

Browse files
committed
Workaround phpstan analysis error
Doctrine hints ObjectRepository when DocumentRepository or EntityRepository is expected
1 parent 6975461 commit 48bf733

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

Document/TokenManager.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
namespace FOS\OAuthServerBundle\Document;
1515

1616
use Doctrine\ODM\MongoDB\DocumentManager;
17+
use Doctrine\ODM\MongoDB\DocumentRepository;
1718
use FOS\OAuthServerBundle\Model\TokenInterface;
1819
use FOS\OAuthServerBundle\Model\TokenManager as BaseTokenManager;
1920

@@ -74,8 +75,10 @@ public function deleteToken(TokenInterface $token)
7475
*/
7576
public function deleteExpired()
7677
{
77-
$result = $this
78-
->dm->getRepository($this->class)
78+
// NOTE: bug in Doctrine, hinting DocumentRepository|ObjectRepository when only DocumentRepository is expected
79+
/** @var DocumentRepository $repository */
80+
$repository = $this->em->getRepository($this->class);
81+
$result = $repository
7982
->createQueryBuilder()
8083
->remove()
8184
->field('expiresAt')->lt(time())

Entity/TokenManager.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
namespace FOS\OAuthServerBundle\Entity;
1515

1616
use Doctrine\ORM\EntityManagerInterface;
17+
use Doctrine\ORM\EntityRepository;
1718
use FOS\OAuthServerBundle\Model\TokenInterface;
1819
use FOS\OAuthServerBundle\Model\TokenManager as BaseTokenManager;
1920

@@ -74,7 +75,10 @@ public function deleteToken(TokenInterface $token)
7475
*/
7576
public function deleteExpired()
7677
{
77-
$qb = $this->em->getRepository($this->class)->createQueryBuilder('t');
78+
// NOTE: bug in Doctrine, hinting EntityRepository|ObjectRepository when only EntityRepository is expected
79+
/** @var EntityRepository $repository */
80+
$repository = $this->em->getRepository($this->class);
81+
$qb = $repository->createQueryBuilder('t');
7882
$qb
7983
->delete()
8084
->where('t.expiresAt < ?1')

0 commit comments

Comments
 (0)