[Bug]: Inconsistency in color usage on watch page

[efb4f5ff-1298-471a-8973-3d47447115dc]

Guidelines

• I have encountered this bug in the latest release of FreeTube.
• I have encountered this bug in the official downloads of FreeTube.
• I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
• I have searched the documentation for information that matches the description of the bug I want to file, without success.
• This issue contains only one bug.

Describe the bug

There are multiple colors being used for Show more, Show less, Click to view comments and View replies.

@efb4f5ff-1298-471a-8973-3d47447115dc The page links are the --link-color variable which is just the --accent-color (Secondary Theme Color) - not sure why we have this one-time-use --link-color variable, but oh well. The comments button is --title-color which is base theme-dependent. For some reason, changing the secondary theme color is changing the rule for the comments button, which shouldn't be happening. You can inspect this more closely with the Dev Tools to see which CSS rules it's applying to figure out where that bug is coming from.

VirtualBoxVM_3J6xUJOT6q.mp4

VirtualBoxVM_gfbkIxR7Ry.mp4

Expected Behavior

Dont use secondary color theme for Show more, Show less, Click to view comments and View replies.

Issue Labels

inconsistent behavior, visual bug

FreeTube Version

https://github.com/FreeTubeApp/FreeTube/actions/runs/12535178475

Operating System Version

Win10 22H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

• I have encountered this bug in the latest nightly build.

[kommunarr]

It looks like this is due to both of the Catppucchin themes setting their title-color to accent-color. CC: @DontBlameMe99

[efb4f5ff-1298-471a-8973-3d47447115dc]

On Dracula it looks a bit purple-ish is that expected?

[kommunarr]

Yes, that theme's title color is bd93f9

[DontBlameMe99]

Is this something that should be reverted? If yes to which colors? I would be able to do this once #6468 is merged?

[kommunarr]

The gist is to use what best color a link/URL/<a> would be in that theme. Look at how the Light, Dark, and Dracula themes handle that for three examples of the approaches you could take.

[DontBlameMe99]

The gist is to use what best color a link/URL/<a> would be in that theme. Look at how the Light, Dark, and Dracula themes handle that for three examples of the approaches you could take.

That makes sense. Should I change this in #6468?

[kommunarr]

Separate bug fix PR would be ideal

[DontBlameMe99]

After it gets merged ig? Then I'll make a PR which fixes both of them?

[kommunarr]

If that's what you prefer, sure! I tend to open multiple PRs and just resolve any merge conflicts based on when they're merged

[DontBlameMe99]

If that's what you prefer, sure! I tend to open multiple PRs and just resolve any merge conflicts based on when they're merged

I could also do this I guess. I thought one PR doing this after it has been merged would be more elegant. But if you think otherwise I can do this as well.

[efb4f5ff-1298-471a-8973-3d47447115dc]

tbh you can do whatever you prefer. Small PR's changes like this one will probably get merged faster than a whole theme

[kommunarr]

Related issue that we should switch to the link-color for the About page links in the same effort due to it being the only apparent instance of mixing the theme colors with a bg-color background, thus failing color contrast issues. Such a fix should check that this succeeds in achieving a sufficient color contrast in this case, otherwise another solution will have to be pursued. More information here.

[github-actions]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Hi @DontBlameMe99 i forgot to follow up on this after your most recent PR was merged. Would it be possible for you to take a look at this issue?

[DontBlameMe99]

Hi @DontBlameMe99 i forgot to follow up on this after your most recent PR was merged. Would it be possible for you to take a look at this issue?

Yes, see #7141