Skip to content

Conversation

@Kokan
Copy link
Contributor

@Kokan Kokan commented Sep 13, 2021

The aim is to be transparent, and allow any freetds.conf configuration option in the ODBC connection-string, so user do not require freetds.conf string.

The aim is to be transparent, and allow any freetds.conf configuration option in the ODBC connection-string, so user do not require freetds.conf string.

Signed-off-by: Kokan <[email protected]>
@fziglio
Copy link

fziglio commented Sep 16, 2021

The patch seems sensible. Some considerations:

  • the options in ODBC are case insensitive, the option in libTDS are case sensitive, I think he easiest fix for this inconsistency would be to have all case insentitive;
  • there's no check for function result, I think we should consider valid_configuration field in odbc_parse_connect_string;
  • odbc_parse_connect_string fills parsed_params for the supported ODBC parameters but not for libTDS options. This feature is used to fill ConnStrOut in SQLDriverConnect allowing to expand the connection string to a full independent connection string. I think we can ignore this but it would be better if we could support this too.

@Kokan
Copy link
Contributor Author

Kokan commented Sep 17, 2021

Thanks for the feedback. I'll update the PR with your points.

@mmcnabb-vms
Copy link
Contributor

@Kokan just looking at this old PR... did you ever make any updates?

@Kokan
Copy link
Contributor Author

Kokan commented Nov 6, 2025

Sadly no. The syslog-ng uses this library, but the payed version used its own fork: https://github.com/balabit-deps/freetds on that fork this exact patch is used.
Also I do not think that I am going to work on this, so I am going to close this MR. But anybody feel free to use the patch if they needed.

@Kokan Kokan closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants