AddonManager never goes further “Checking connection”

[StSav012]

Here reply is always None, rendering the function useless. That's a known peculiarity of PySide6.

AddonManager/NetworkManager.py

Line 550 in a38c8f0

reply: QtNetwork.QNetworkReply = self.sender()

As a workaround against that, I suggest changing

AddonManager/NetworkManager.py

Line 256 in a38c8f0

reply.finished.connect(self.__reply_finished)

to

        reply.finished.connect(lambda r=reply: self.__reply_finished(r))

and

AddonManager/NetworkManager.py

Lines 547 to 550 in a38c8f0

	def __reply_finished(self) -> None:
	"""Called when a reply has been completed: this makes sure the data has been read and
	any notifications have been called."""
	reply: QtNetwork.QNetworkReply = self.sender()

to

     def __reply_finished(self, reply: QtNetwork.QNetworkReply | None = None) -> None:
         """Called when a reply has been completed: this makes sure the data has been read and
         any notifications have been called."""
         if reply is None:
             reply = self.sender()

to maintain the compatibility with calls I might've missed. I find the solution dirty, but it works.

There are many more places like this, even in the file. That's the reason I make the issue, not a PR.

---

FreeCAD Info:

OS: Manjaro Linux (KDE/plasma/wayland)
Architecture: x86_64
Version: 1.0.2.39319 (Git)
Build type: Release
Branch: makepkg
Hash: 256fc7eff3379911ab5daf88e10182c509aa8052
Python 3.13.7, Qt 6.10.1, Coin 4.0.5, Vtk 9.5.2, OCC 7.9.2
Locale: English/United States (en_US)
Stylesheet/Theme/QtStyle: FreeCAD Dark.qss/FreeCAD Dark/
Installed mods:

• CADExchanger
• fasteners-backup-before-zip-migration 0.5.33 (Disabled) ← this proves the changes work well!
• fasteners 0.5.43
• pcb 6.2023.1
• manifest.json

[chennes]

Here reply is always None, rendering the function useless. That's a known peculiarity of PySide6.

Thanks for the research. Is there documentation about that someplace? is this specific to a particular Qt version or platform?

[StSav012]

I can't find a piece of documentation reading about this, but people across the Internet discuss it quite intensively:
https://search.brave.com/search?q=qt6%20sender%20is%20null
I guess the root cause of this is that QNetworkReply comes from another thread. But I actually have little to no idea. I swear I faced the issue exactly four years ago (I've found the commit from Jan. 17, 2022) in a pet project of mine. And the fix was the same, i.e., a lambda function. But today, I can't reproduce that issue with the same code. And this makes it more puzzling to see a sender() being None in FreeCAD.

Do you receive a correct sender() there? What's your setup?

[chennes]

I do receive the correct sender(), on many different platforms (this code has been around for a couple of years now). But I am amenable to a workaround if this issue is common and can be replicated. Can you write a test demonstrating the failure and let's see if any of the CI runners choke on it?

[StSav012]

I'm on it. Not ready yet.

Meanwhile, I couldn't run the tests without some changes.

Lines

AddonManager/TestAddonManagerGui.py

Lines 29 to 34 in 61456a1

	from AddonManagerTest.gui.test_workers_startup import (
	TestWorkersStartup as AddonManagerTestWorkersStartup,
	)
	from AddonManagerTest.gui.test_installer_gui import (
	TestInstallerGui as AddonManagerTestInstallerGui,
	)

AddonManager/TestAddonManagerGui.py

Lines 38 to 40 in 61456a1

	from AddonManagerTest.gui.test_update_all_gui import (
	TestUpdateAllGui as AddonManagerTestUpdateAllGui,
	)

lead to import failure.
I presume they should be

from AddonManagerTest.app.test_workers_startup import (
    TestCreateAddonListWorker as AddonManagerTestWorkersStartup,
)
from AddonManagerTest.gui.test_installer_gui import (
    TestAddonInstallerGUI as AddonManagerTestInstallerGui,
)

from AddonManagerTest.gui.test_update_all_gui import (
    TestUpdateAllGUI as AddonManagerTestUpdateAllGui,
)

But I'm unsure about the first import.

---

While running main.py, I get (redacted)

Error calling Python override of QThread::run(): Traceback (most recent call last):
  File "addonmanager_workers_startup.py", line 81, in run
    self.process_addon_cache(addon_cache)
    ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
  File "addonmanager_workers_startup.py", line 227, in process_addon_cache
    manifest = InstallationManifest(catalog)
  File "addonmanager_installation_manifest.py", line 75, in __init__
    self._migrate_to_manifest_file(catalog)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "addonmanager_installation_manifest.py", line 85, in _migrate_to_manifest_file
    dirs_in_mod = os.listdir(fci.DataPaths().mod_dir)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmp………'

because in

AddonManager/addonmanager_installation_manifest.py

Lines 83 to 85 in 61456a1

	if not os.path.exists(fci.DataPaths().mod_dir):
	os.makedirs(fci.DataPaths().mod_dir)
	dirs_in_mod = os.listdir(fci.DataPaths().mod_dir)

every call to fci.DataPaths() creates a new temporary directory in the test. To avoid this,

AddonManager/addonmanager_freecad_interface.py

Lines 252 to 262 in 61456a1

	self.reference_count += 1
	if self.data_dir is None:
	self.data_dir = tempfile.mkdtemp()
	if self.mod_dir is None:
	self.mod_dir = tempfile.mkdtemp()
	if self.cache_dir is None:
	self.cache_dir = tempfile.mkdtemp()
	if self.macro_dir is None:
	self.macro_dir = tempfile.mkdtemp()
	if self.home_dir is None:
	self.home_dir = os.path.join(os.path.dirname(__file__))

should be

            DataPaths.reference_count += 1
            if DataPaths.data_dir is None:
                DataPaths.data_dir = tempfile.mkdtemp()
            if DataPaths.mod_dir is None:
                DataPaths.mod_dir = tempfile.mkdtemp()
            if DataPaths.cache_dir is None:
                DataPaths.cache_dir = tempfile.mkdtemp()
            if DataPaths.macro_dir is None:
                DataPaths.macro_dir = tempfile.mkdtemp()
            if DataPaths.home_dir is None:
                DataPaths.home_dir = os.path.join(os.path.dirname(__file__))

And for FreeCAD being True, I suppose. (Where's DataPaths.reference_count += 1 there?) Using typing.ClassVar might help.

But even then, a temporary directory gets created when I call fci.DataPaths().mod_dir. However, calling just DataPaths().mod_dir from within addonmanager_freecad_interface.py works as I've described.

I'd re-write the code like this:

import atexit


class DataPaths:
    """Provide access to various data storage paths. If not running within FreeCAD,
    all paths are temp directories. If not run within FreeCAD, all directories are
    deleted when the last reference to this class is deleted."""

    if FreeCAD:
        data_dir = getUserAppDataDir()
        mod_dir = os.path.join(getUserAppDataDir(), "Mod")
        cache_dir = getUserCachePath()
        macro_dir = getUserMacroDir(True)
        home_dir = FreeCAD.getHomePath()
    else:
        data_dir = tempfile.mkdtemp()
        mod_dir = tempfile.mkdtemp()
        cache_dir = tempfile.mkdtemp()
        macro_dir = tempfile.mkdtemp()
        home_dir = os.path.join(os.path.dirname(__file__))


def _delete_paths():
    if FreeCAD:
        return
    paths = [DataPaths.data_dir, DataPaths.mod_dir, DataPaths.cache_dir, DataPaths.macro_dir, DataPaths.mod_dir]
    for path in paths:
        if os.path.isdir(path):
            shutil.rmtree(path)


atexit.register(_delete_paths)

---

Then,

AddonManager/AddonManager.py

Lines 179 to 180 in 01e242e

	if not first_run_dialog.exec():
	return

should be

        if not first_run_dialog.exec():
            self.finished.emit()
            return

for the app to gracefully exit if a user disagrees.

[StSav012]

I can reproduce the issue with the following code fed into freecad -c:

import main  # to create an instance of `QApplication`
from AddonManager import NetworkManager, ConnectionCheckerGUI
NetworkManager.InitializeNetworkManager()
cc = ConnectionCheckerGUI()
cc.start()

However, if I run

from main import app
from AddonManager import NetworkManager, ConnectionCheckerGUI
NetworkManager.InitializeNetworkManager()
cc = ConnectionCheckerGUI()
cc.check_complete.connect(app.quit)
cc.start()
app.exec()

in an ordinary Python, the checker runs smoothly.

So, I've got a couple of points:

1. Please see if the checker fails when run from freecad -c. Is there a way to pass a file there and not to copy-paste the lines every time? I mean, I can always do freecad -c < cc_test.py. As a side note, running tests this way fails for a reason irrelevant to the issue.
2. Please check if the First-Run Dialog can be cancelled without hanging processes. I've updated the previous comment to point at a branch that troubles me.

[StSav012]

Yesterday, I tested Addon Manager coming with the flatpak package of FreeCAD on Ubuntu 24.04. The issue did not appear there.