Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write unit tests #1

Open
lourot opened this issue Jun 6, 2023 · 3 comments
Open

Write unit tests #1

lourot opened this issue Jun 6, 2023 · 3 comments
Assignees
@killerkc12
Labels
good first issue Good for newcomers

Comments

@lourot
Copy link
Member

lourot commented Jun 6, 2023

No description provided.

@lourot lourot added the good first issue Good for newcomers label Jun 6, 2023
@killerkc12
Copy link
Contributor

@AurelienLourot If this issue is still open, can I pick this up?

@lourot
Copy link
Member Author

lourot commented Aug 20, 2023

Hey @killerkc12 👋 Yes this is still open, thanks a lot! Let me know if you have any questions

@killerkc12
Copy link
Contributor

@AurelienLourot I was going through the codebase.
I've seen test script is explicitly looking for jest.config.json, can we directly use the jest package here?
Also if we use the jest, it will directly use the jest.config.js (will create a new file) where we can use the global config.
If you're ok, I can give a PR

lourot added a commit that referenced this issue Aug 20, 2023
@lourot
Call jest directly instead of 'tsdx test' // #1
6e1e417
lourot added a commit that referenced this issue Aug 20, 2023
@lourot
Merge pull request #29 from Frameright/quality/jest
06717b7 
Call jest directly instead of 'tsdx test' // #1
@killerkc12 killerkc12 mentioned this issue Aug 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@killerkc12 killerkc12

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lourot @killerkc12