refactor(idevaffiliate): refactor to ease tests and understanding

Author: ndvo

src/foxy/FoxyWebhook.js

@@ -185,7 +185,6 @@ function validFoxyRequest(requestEvent) {
   try {
     JSON.parse(requestEvent.body);
   } catch (e) {
-    console.log('body' , requestEvent.body);
     err = 'Payload is not valid JSON.';
   }
   return err;

src/functions/cart/cart.js

@@ -184,9 +184,10 @@ cartRouter.get(
       return;
     }
     setup();
-    if (!req.params.cartId) {
-      throw createError(400, `cartId not found.`);
-    }
+    // This code is never executed
+    //if (!req.params.cartId) {
+    //  throw createError(400, `cartId not found.`);
+    //}
     await getCart(req.params.cartId)
       .then(async (cart) => {
         if (!validateCart(cart)) {

src/functions/idevaffiliate-marketplace/idevaffiliate-marketplace.js

@@ -4,92 +4,89 @@ const fetch = require("node-fetch");
 const FoxyWebhook = require("../../foxy/FoxyWebhook.js");
 
 const { URLSearchParams } = require("url");
-const { FoxyApi } = require("@foxy.io/node-api");
-
 
 const idevApiUrl = config.idevAffiliate.apiUrl || "";
 const idevSecretKey = config.idevAffiliate.secretKey || "";
 const foxyWebhookEncryptionKey = config.foxy.webhook.encryptionKey || "";
 
-const getFoxyApi = () => new FoxyApi();
-
 const getAffiliateIdFromProduct = (productCode) => {
-  if (productCode.match(/\-a(\d+)$/i)) {
-    return productCode.match(/\-a(\d+)$/i)[1];
-  }
-  return null;
+  const m = productCode.match(/-a(\d+)$/i)
+  return m ? m[1] : null;
 };
 
 // TODO: Use this method instead of just referencing the `price`,
 // as `price` doesn't include discounts, modifiers, coupons, etc.
 const getProductNetPrice = (productCode, webhook) => {};
 
-const pushToIdev = async (item, webhook) => {
+/**
+ * Push a single item to Idev affiliate
+ *
+ * @param {Object} item to be pushed
+ * @param {string|number} webhookId the id of the webhook.
+ * @returns {Promise} that resolves to the response of the posting to Idev.
+ */
+function pushToIdev (item, webhookId) {
   if (!item.name || !item.code || !item.price) {
     return false;
   }
   const params = new URLSearchParams();
   params.append("affiliate_id", getAffiliateIdFromProduct(item.code));
   params.append("idev_saleamt", item.price);
-  params.append("idev_ordernum", webhook.id);
+  params.append("idev_ordernum", webhookId);
   // TODO: Check an existing attribute to see if this has already been done.
   // Upsert a Foxy API attribute on the product after pushing so it's not duplicated
   // with a re-run of the webhook.
   return fetch(idevApiUrl, {
-    method: "POST",
     body: params,
+    method: "POST",
   });
-};
+}
 
-const processTransaction = async (message) => {
-  const promises = [];
-  try {
-    for (let i = 0; i < message._embedded["fx:items"].length; i++) {
-      const item = message._embedded["fx:items"][i];
-      promises.push(pushToIdev(item, message));
-    }
-  } catch (error) {
-    console.log("ERROR in processTransaction:", error);
-    console.log(message);
-  }
-  return Promise.all(promises);
-};
+/**
+ * Processes all transactions within a message.
+ *
+ * @param {Object} message to be processed
+ * @returns {Promise} that resolves to the completion of the processes of all
+ * transactions.
+ */
+async function processTransaction (message) {
+  return Promise.all(message._embedded["fx:items"]
+      .map(i => pushToIdev(i, message.id))
+  );
+}
 
 /**
  * Verifies the request as a valid Foxy webhook.
  * @param (string) - The message payload, described here: https://wiki.foxycart.com/v/2.0/webhooks#example_payload
  */
-
-exports.handler = async (event, context) => {
-  const foxy = getFoxyApi();
-  const err = FoxyWebhook.validFoxyRequest(event);
+exports.handler = async (requestEvent) => {
+  const err = FoxyWebhook.validFoxyRequest(requestEvent);
   if (err) {
-    return FoxyWebhook.response(err);
+    return FoxyWebhook.response(err, 400);
   }
-  const payload = JSON.parse(event.body);
+  const payload = JSON.parse(requestEvent.body);
   // Make sure everything looks ok
+  if (requestEvent.headers["foxy-webhook-event"] !== "transaction/created") {
+    return FoxyWebhook.response('Unsupported event.', 501);
+  }
   if (
-    event.headers["foxy-webhook-event"] !== "transaction/created" ||
     !payload._embedded ||
     !payload._embedded["fx:items"] ||
     !payload._embedded["fx:items"].length > 0
   ) {
-    return FoxyWebhook.response("Invalid payload.");
+    return FoxyWebhook.response("Invalid payload.", 400);
   }
-  return processTransaction(payload)
-    .then((data) => {
-      return {
-        statusCode: 200,
-        body: JSON.stringify({ message: "success." }),
-      };
-    })
-    .catch((err) => {
-      console.log("ERROR:");
-      console.log(err);
-      console.log(payload);
-      return {
-        statusCode: 400,
-        body: JSON.stringify({ message: "error. check logs." }),
-      };
-    });
-};
+  try {
+    await processTransaction(payload);
+    return {
+      body: JSON.stringify({ message: "success." }),
+      statusCode: 200,
+    };
+  } catch (e) {
+    console.error("ERROR:", err);
+    return {
+      body: JSON.stringify({ message: "error. check logs." }),
+      statusCode: 400,
+    };
+  }
+}

test/functions/idevaffiliate-marketplace/idevaffiliate-marketplace.test.js

@@ -1,16 +1,17 @@
 const { after, afterEach, before, beforeEach, describe, it } = require("mocha");
 const {expect} = require("chai");
 const rewire = require("rewire");
+const MockFoxyRequests = require("../../MockFoxyRequests.js");
 
 
 const chaiHttp = require('chai-http');
-const handler = rewire('../../../src/functions/idevaffiliate-marketplace/idevaffiliate-marketplace.js');
-const config = handler.__get__('config');
+const IdevAffiliate = rewire('../../../src/functions/idevaffiliate-marketplace/idevaffiliate-marketplace.js');
+const config = IdevAffiliate.__get__('config');
 
-
-
-function setConfig() {
-}
+let sentRequests = [];
+IdevAffiliate.__set__('fetch', function () {
+  sentRequests.push(arguments);
+});
 
 describe("Idev Affiliate", function() {
 
@@ -20,9 +21,49 @@ describe("Idev Affiliate", function() {
     }
   );
 
-  it ("Should require Foxy Client Id", async function () {
-    expect(async () => {await handler({})}).to.throw;
+  beforeEach(
+    function () {
+      sentRequests = [];
+    }
+  );
+
+  it ("Should validate requests", async function () {
+    const response = await IdevAffiliate.handler({});
+    expect(response.statusCode).to.equal(400);
+    expect(JSON.parse(response.body).details).to.equal("Payload is not valid JSON.");
   });
 
+  it ("Should inform of unsupported evets", async function () {
+    const request = MockFoxyRequests.validRequest();
+    request.headers['foxy-webhook-event'] = 'validation/payment';
+    const response = await IdevAffiliate.handler(request);
+    expect(response.statusCode).to.equal(501);
+    expect(JSON.parse(response.body).details).to.equal("Unsupported event.");
+  });
+
+  it ("Should send items to Idev Affiliate", async function () {
+    const request = MockFoxyRequests.validRequest({
+      _embedded: {
+        'fx:items': [
+          {code: 'foo', name: 'foo', price: 1},
+          {code: 'bar', name: 'bar', price: 2},
+        ]
+      }
+    });
+    request.headers['foxy-webhook-event'] = 'transaction/created';
+    const response = await IdevAffiliate.handler(request);
+    expect(sentRequests.map(i => i[1].body)
+      .every(i => i.has('affiliate_id') &&
+        i.has('idev_saleamt') &&
+        i.has('idev_ordernum')
+      )).to.be.true;
+    expect(response.statusCode).to.equal(200);
+  });
+  
+
+
+
+
+
 
 });