address comments

g31pranjal · g31pranjal · commit d9d2f2eeb94e · 2025-07-14T23:07:51.000+01:00
diff --git a/fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/RelationalArrayFacade.java b/fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/RelationalArrayFacade.java
@@ -79,7 +79,7 @@ class RelationalArrayFacade implements RelationalArray {
 
     @Nullable
     private DataType.ArrayType computeType() {
-        return delegateMetadata.getType() == Type.NO_TYPE ? null :
+        return delegateMetadata.getType() == Type.UNKNOWN ? null :
                DataType.ArrayType.from(RelationalStructFacade.RelationalStructFacadeMetaData.getDataType(delegateMetadata.getType(), delegateMetadata, delegateMetadata.getNullable()));
     }
 
diff --git a/fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/TypeConversion.java b/fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/TypeConversion.java
@@ -475,7 +475,7 @@ static DataType.StructType getStructDataType(@Nonnull List<ColumnMetadata> colum
         final var structFields = new ArrayList<DataType.StructType.Field>();
         for (int i = 0; i < columnMetadataList.size(); i++) {
             final var colMetadata = columnMetadataList.get(i);
-            if (colMetadata.getType() == Type.NO_TYPE) {
+            if (colMetadata.getType() == Type.UNKNOWN) {
                 return null;
             }
             final var dataType = getDataType(colMetadata.getType(), colMetadata, colMetadata.getNullable());

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ class RelationalArrayFacade implements RelationalArray {`
`79`	`79`
`80`	`80`	`@Nullable`
`81`	`81`	`private DataType.ArrayType computeType() {`
`82`		`- return delegateMetadata.getType() == Type.NO_TYPE ? null :`
	`82`	`+ return delegateMetadata.getType() == Type.UNKNOWN ? null :`
`83`	`83`	`DataType.ArrayType.from(RelationalStructFacade.RelationalStructFacadeMetaData.getDataType(delegateMetadata.getType(), delegateMetadata, delegateMetadata.getNullable()));`
`84`	`84`	`}`
`85`	`85`
Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ static DataType.StructType getStructDataType(@Nonnull List<ColumnMetadata> colum`
`475`	`475`	`final var structFields = new ArrayList<DataType.StructType.Field>();`
`476`	`476`	`for (int i = 0; i < columnMetadataList.size(); i++) {`
`477`	`477`	`final var colMetadata = columnMetadataList.get(i);`
`478`		`- if (colMetadata.getType() == Type.NO_TYPE) {`
	`478`	`+ if (colMetadata.getType() == Type.UNKNOWN) {`
`479`	`479`	`return null;`
`480`	`480`	`}`
`481`	`481`	`final var dataType = getDataType(colMetadata.getType(), colMetadata, colMetadata.getNullable());`