Skip to content

Commit 2adcfc4

Browse files
committed
fixes
1 parent ab972a5 commit 2adcfc4

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

fdb-relational-core/src/test/java/com/apple/foundationdb/relational/compare/JDBCRelationalResultSet.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,6 @@ public Clob getClob(String columnLabel) throws SQLException {
601601

602602
@Override
603603
public RelationalArray getArray(String columnLabel) throws SQLException {
604-
//TODO(bfines) this almost certainly won't work
605604
return delegate.getArray(columnLabel);
606605
}
607606

@@ -613,7 +612,6 @@ public UUID getUUID(final int oneBasedPosition) throws SQLException {
613612
@Override
614613
public UUID getUUID(final String fieldName) throws SQLException {
615614
return delegate.getUUID(fieldName);
616-
return delegate.getArray(columnLabel);
617615
}
618616

619617
@Override

fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/TypeConversion.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,29 +21,29 @@
2121
package com.apple.foundationdb.relational.jdbc;
2222

2323
import com.apple.foundationdb.annotation.API;
24-
2524
import com.apple.foundationdb.relational.api.ArrayMetaData;
2625
import com.apple.foundationdb.relational.api.Continuation;
27-
import com.apple.foundationdb.relational.api.SqlTypeNamesSupport;
28-
import com.apple.foundationdb.relational.api.StructMetaData;
2926
import com.apple.foundationdb.relational.api.RelationalArray;
3027
import com.apple.foundationdb.relational.api.RelationalResultSet;
3128
import com.apple.foundationdb.relational.api.RelationalResultSetMetaData;
3229
import com.apple.foundationdb.relational.api.RelationalStruct;
3330
import com.apple.foundationdb.relational.api.RelationalStructMetaData;
31+
import com.apple.foundationdb.relational.api.SqlTypeNamesSupport;
32+
import com.apple.foundationdb.relational.api.StructMetaData;
3433
import com.apple.foundationdb.relational.api.exceptions.ErrorCode;
3534
import com.apple.foundationdb.relational.jdbc.grpc.v1.KeySet;
3635
import com.apple.foundationdb.relational.jdbc.grpc.v1.KeySetValue;
3736
import com.apple.foundationdb.relational.jdbc.grpc.v1.ResultSet;
38-
import com.apple.foundationdb.relational.jdbc.grpc.v1.RpcContinuationReason;
3937
import com.apple.foundationdb.relational.jdbc.grpc.v1.ResultSetMetadata;
4038
import com.apple.foundationdb.relational.jdbc.grpc.v1.RpcContinuation;
39+
import com.apple.foundationdb.relational.jdbc.grpc.v1.RpcContinuationReason;
4140
import com.apple.foundationdb.relational.jdbc.grpc.v1.column.Array;
4241
import com.apple.foundationdb.relational.jdbc.grpc.v1.column.Column;
4342
import com.apple.foundationdb.relational.jdbc.grpc.v1.column.ColumnMetadata;
4443
import com.apple.foundationdb.relational.jdbc.grpc.v1.column.ListColumn;
4544
import com.apple.foundationdb.relational.jdbc.grpc.v1.column.ListColumnMetadata;
4645
import com.apple.foundationdb.relational.jdbc.grpc.v1.column.Struct;
46+
import com.apple.foundationdb.relational.jdbc.grpc.v1.column.Uuid;
4747
import com.apple.foundationdb.relational.util.PositionalIndex;
4848
import com.google.common.annotations.VisibleForTesting;
4949
import com.google.protobuf.ByteString;

fdb-relational-jdbc/src/main/java/com/apple/foundationdb/relational/jdbc/ParameterHelper.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.apple.foundationdb.relational.api.exceptions.ErrorCode;
2525
import com.apple.foundationdb.relational.jdbc.grpc.v1.Parameter;
2626
import com.apple.foundationdb.relational.jdbc.grpc.v1.column.Column;
27+
import com.apple.foundationdb.relational.jdbc.grpc.v1.column.Uuid;
2728
import com.google.protobuf.ByteString;
2829

2930
import java.sql.Array;

yaml-tests/src/main/java/com/apple/foundationdb/relational/yamltests/command/QueryInterpreter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,7 @@ private QueryParameterYamlConstructor(LoaderOptions loaderOptions) {
111111

112112
@Override
113113
public Parameter constructObject(Node node) {
114-
if (node.getTag().equals(RANDOM_TAG) || node.getTag().equals(ARRAY_GENERATOR_TAG) || node.getTag().equals(IN_LIST_TAG) || node.getTag().equals(NULL_TAG)
115-
|| node.getTag().equals(UUID_TAG)) {
114+
if (node.getTag().equals(RANDOM_TAG) || node.getTag().equals(ARRAY_GENERATOR_TAG) || node.getTag().equals(IN_LIST_TAG) || node.getTag().equals(NULL_TAG) || node.getTag().equals(UUID_TAG)) {
116115
return (Parameter) super.constructObject(node);
117116
} else if (node instanceof SequenceNode) {
118117
// simple list

0 commit comments

Comments
 (0)