revert releasenote change

Author: pengpeng-lu

docs/sphinx/source/ReleaseNotes.md

@@ -20,7 +20,7 @@ Users performing online updates are encouraged to update from [4.0.559.4](#40559
 <h4> New Features </h4>
 
 * FRL respects PLAN_CACHE_*_MAX_ENTRIES - [PR #3156](https://github.com/FoundationDB/fdb-record-layer/pull/3156)
-  <h4> Bug Fixes </h4>
+<h4> Bug Fixes </h4>
 
 * Use `Locale.ROOT` in `String.format`, fixing messages if JVM has non-US default locale - [PR #3117](https://github.com/FoundationDB/fdb-record-layer/pull/3117)
 
@@ -62,10 +62,10 @@ Mixed mode testing run against the following previous versions:
 * Support Lucene index scrubbing of missing entries - [PR #3009](https://github.com/FoundationDB/fdb-record-layer/pull/3009)
 * Add enum column support to relational server - [PR #3074](https://github.com/FoundationDB/fdb-record-layer/pull/3074)
 * Add validation to Insert statement parsing to match the column names with supplied values - [PR #3070](https://github.com/FoundationDB/fdb-record-layer/pull/3070)
-  <h4> Bug Fixes </h4>
+<h4> Bug Fixes </h4>
 
 * Plan Hash Instability in recursive union query - [PR #3142](https://github.com/FoundationDB/fdb-record-layer/pull/3142)
-  <h4> Dependency Updates </h4>
+<h4> Dependency Updates </h4>
 
 * Update grpc-commonProtos, assertj, and junit dependencies - [PR #3115](https://github.com/FoundationDB/fdb-record-layer/pull/3115)
 * Bump spotbugs gradle plugin from 4.6.1 to 6.1.3 - [PR #3104](https://github.com/FoundationDB/fdb-record-layer/pull/3104)
@@ -107,13 +107,13 @@ Mixed mode testing run against the following previous versions:
 <h4> New Features </h4>
 
 * Plan generator now uses Cascades's `FunctionCatalog` - [PR #3061](https://github.com/FoundationDB/fdb-record-layer/pull/3061)
-  <h4> Bug Fixes </h4>
+<h4> Bug Fixes </h4>
 
 * Exclude transitive maven information in shaded jar - [PR #3129](https://github.com/FoundationDB/fdb-record-layer/pull/3129)
 * Fix the publication of `fdb-record-layer-core-shaded` jars so that only the correct artifacts get uploaded - [PR #3125](https://github.com/FoundationDB/fdb-record-layer/pull/3125)
 * Set skip and limit for the recursive union cursor correctly - [PR #3111](https://github.com/FoundationDB/fdb-record-layer/pull/3111)
 * Fix infinite continuations when NULL_ON_EMPTY is in the plan - [PR #3092](https://github.com/FoundationDB/fdb-record-layer/pull/3092)
-  <h4> Dependency Updates </h4>
+<h4> Dependency Updates </h4>
 
 * Upgrade the versions gradle plugin from 0.38.0 to 0.52.0 - [PR #3106](https://github.com/FoundationDB/fdb-record-layer/pull/3106)
 * Upgrade de.undercouch.download gradle plugin from 4.1.1 to 5.6.0 - [PR #3088](https://github.com/FoundationDB/fdb-record-layer/pull/3088)
@@ -160,7 +160,7 @@ Our API stability annotations have been updated to reflect greater API instabili
 <h4> Breaking Changes </h4>
 
 * Only allow continuation to be returned after a result set has been exhausted - [PR #3038](https://github.com/FoundationDB/fdb-record-layer/pull/3038)
-  <h4> Dependency Updates </h4>
+<h4> Dependency Updates </h4>
 
 * Upgrade git-version plugin to the latest version: 3.1.0 - [PR #3089](https://github.com/FoundationDB/fdb-record-layer/pull/3089)
 * Upgrade jmh plugin to latest version: 0.7.2 - [PR #3090](https://github.com/FoundationDB/fdb-record-layer/pull/3090)
@@ -219,7 +219,7 @@ Our API stability annotations have been updated to reflect greater API instabili
 <h4> New Features </h4>
 
 * Support enums in relational operations - [PR #3012](https://github.com/FoundationDB/fdb-record-layer/pull/3012)
-  <h4> Bug Fixes </h4>
+<h4> Bug Fixes </h4>
 
 * Break out a helper class from GenerateVisitor annotation processor - [PR #3060](https://github.com/FoundationDB/fdb-record-layer/pull/3060)
 
@@ -287,7 +287,7 @@ Our API stability annotations have been updated to reflect greater API instabili
 * Add support for continuations to the relational server - [PR #3030](https://github.com/FoundationDB/fdb-record-layer/pull/3030)
 * Introduce SQL support to Recursive CTEs - [PR #3035](https://github.com/FoundationDB/fdb-record-layer/pull/3035)
 * Align aggregate query behaviour on empty tables more towards SQL standard - [PR #3029](https://github.com/FoundationDB/fdb-record-layer/pull/3029)
-  <h4> Dependency Updates </h4>
+<h4> Dependency Updates </h4>
 
 * Bump black from 22.10.0 to 24.3.0 in /scripts - [PR #3024](https://github.com/FoundationDB/fdb-record-layer/pull/3024)
 
@@ -382,7 +382,7 @@ Our API stability annotations have been updated to reflect greater API instabili
 
 ### Breaking Changes
 
-The Apache Commons library has been removed as a dependency. There were a few locations where the `Pair` class from that library was exposed via the API. This has necessitated making API incompatible changes. These have mostly been replaced by classes defined in the repository, or with other JDK classes.
+The Apache Commons library has been removed as a dependency. There were a few locations where the `Pair` class from that library was exposed via the API. This has necessitated making API incompatible changes. These have mostly been replaced by classes defined in the repository, or with other JDK classes. 
 
 
 ### 3.5.556.0
@@ -405,10 +405,10 @@ Starting with version [3.4.455.0](#344550), the semantics of `UnnestedRecordType
 ### 3.4.554.0
 
 * `DefaultTextTokenizer` (and `TextTokenizer`s that use it) now uses `Locale.ROOT` for tokenizing instead of the default
-  locale. This could have an impact if it's being used in an environment with a default locale that is not compatible with
-  `Locale.ROOT` for this purpose. For example if the default locale is `th`, Thai text may be tokenized differently with
-  this version. This also means that if you have TEXT indexes using one of these tokenizers, they will need to be rebuilt
-  with the new code.
+locale. This could have an impact if it's being used in an environment with a default locale that is not compatible with
+`Locale.ROOT` for this purpose. For example if the default locale is `th`, Thai text may be tokenized differently with
+this version. This also means that if you have TEXT indexes using one of these tokenizers, they will need to be rebuilt
+with the new code.
 
 
 * **Bug fix** DefaultTextTokenizer behaved differently depending on system locale [(Issue #2966)](https://github.com/FoundationDB/fdb-record-layer/issues/2966)
@@ -503,7 +503,7 @@ Starting with version [3.4.455.0](#344550), the semantics of `UnnestedRecordType
 * **Bug fix** Expose `Tuple`-based `MIN_EVER` and `MAX_EVER` indexes to Cascades [(Issue #2874)](https://github.com/FoundationDB/fdb-record-layer/issues/2874)
 * **Bug fix** Log Repartitioned records after writing them [(Issue #2867)](https://github.com/FoundationDB/fdb-record-layer/issues/2867)
 * **Bug fix** Lucene merges: false no merges found [(Issue #2864)](https://github.com/FoundationDB/fdb-record-layer/issues/2864)
-* **Feature** Deprecate special IndexingByRecords functions [(Issue #2259)](https://github.com/FoundationDB/fdb-record-layer/issues/2259)
+* **Feature** Deprecate special IndexingByRecords functions [(Issue #2259)](https://github.com/FoundationDB/fdb-record-layer/issues/2259) 
 
 ### 3.4.531.0
 
@@ -1455,12 +1455,12 @@ The Guava dependency version has been updated to 31.1. Projects may need to chec
 ### Features
 
 This version of the Record Layer allows the FDB API version to be configured through the `FDBDatabaseFactory`. This means that while this version allows the client to be configured to use 7.1 features, it also supports connecting to 6.3 FDB clusters if the API version is set appropriately. Note that setting the API version does restrict the set of potential FDB server versions that can be connected to, so this configuration change should only be made if the FDB server has already been updated.
-
-New index state "READABLE_UNIQUE_PENDING" - the proper way to roll this feature out is:
+ 
+New index state "READABLE_UNIQUE_PENDING" - the proper way to roll this feature out is: 
 1. The adopter should upgrade to the new Record Layer version and deploy the version everywhere.
 2. The format version should be set READABLE_UNIQUE_PENDING_FORMAT_VERSION.
 3. Only after all the possible clients are upgraded to support the new state, the adopter may set the allowPendingState on the indexing policy of new index builds.
-   An index may be in this new state if it is fully built, the unique flag is set, and duplications were found during online indexing. From the code point of view, it is defined as scannable but not readable.
+An index may be in this new state if it is fully built, the unique flag is set, and duplications were found during online indexing. From the code point of view, it is defined as scannable but not readable. 
 
 
 ### Breaking Changes
@@ -1697,7 +1697,7 @@ This version of the Record Layer changes the Java source and target compatibilit
 ### 3.1.238.0
 
 * **Feature** Support custom additional synonyms. This introduces a new SynonymMapRegistry.
-  New synonym maps should implement `SynonymMapConfig`. See example `EnglishSynonymMap`.
+New synonym maps should implement `SynonymMapConfig`. See example `EnglishSynonymMap`.
 
 ### 3.1.237.0
 
@@ -1719,10 +1719,10 @@ This version of the Record Layer changes the Java source and target compatibilit
 
 * **Feature** Expose IndexQueryabilityFilter for Aggregate planning [(Issue #1520)](https://github.com/FoundationDB/fdb-record-layer/issues/1520)
 * **Breaking change** As part of [(Issue #1520)](https://github.com/FoundationDB/fdb-record-layer/issues/1520) implementers
-  of `FDBRecordStoreBase` need to implement a new overload of `getSnapshotRecordCountForRecordType` and `evaluateAggregateFunction`
-  that takes an `IndexQueryabilityFilter`. In addition some methods on `IndexFunctionHelper` and `ComposedBitmapIndexAggregate`
-  now take an `IndexQueryabilityFilter`; to preserve backwards compatibility, if all indexes are valid,
-  `IndexQueryabilityFilter.TRUE` can be used.
+of `FDBRecordStoreBase` need to implement a new overload of `getSnapshotRecordCountForRecordType` and `evaluateAggregateFunction`
+that takes an `IndexQueryabilityFilter`. In addition some methods on `IndexFunctionHelper` and `ComposedBitmapIndexAggregate`
+now take an `IndexQueryabilityFilter`; to preserve backwards compatibility, if all indexes are valid,
+`IndexQueryabilityFilter.TRUE` can be used.
 
 ### 3.1.231.0
 
@@ -1813,7 +1813,7 @@ Another, smaller change that has been made is that by default, new indexes added
 ### 3.0.210.0
 
 * **Bug fix** relax conditions enforced in ImplementInUnionRule [(Issue #1369)](https://github.com/FoundationDB/fdb-record-layer/issues/1369)
-  *OnlineIndexScrubberTest.testScrubberLimits - reduce number of records [(Issue #1363)](https://github.com/FoundationDB/fdb-record-layer/issues/1363)
+*OnlineIndexScrubberTest.testScrubberLimits - reduce number of records [(Issue #1363)](https://github.com/FoundationDB/fdb-record-layer/issues/1363)
 * OnlineIndexScrubber: clear ranges when exhausted [(Issue #1367)](https://github.com/FoundationDB/fdb-record-layer/issues/1367)
 * **Feature** Prototype non-index sorting [(Issue #1161)](https://github.com/FoundationDB/fdb-record-layer/issues/1161)
 
@@ -2195,7 +2195,7 @@ This version of the Record Layer requires a FoundationDB server version of at le
 
 Constructors of the `RecordQueryUnionPlan` and `RecordQueryIntersectionPlan` have been marked as deprecated in favor of static initializers. This will allow for more flexibility as work on the new planner develops.
 
-### Newly Deprecated
+### Newly Deprecated 
 
 The non-static `RecordCursor::flatMapPipelined()` method has been deprecated because it is easy to mis-use (by mistaken analogy to the `mapPipelined()` method) and cannot be used with continuations. See [Issue #665](https://github.com/FoundationDB/fdb-record-layer/issues/665) for further explanation.
 

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/cursors/aggregate/AggregateCursor.java

@@ -61,12 +61,13 @@ public class AggregateCursor<M extends Message> implements RecordCursor<QueryRes
     // last row in last group, is null if the current group is the first group
     @Nullable
     private RecordCursorResult<QueryResult> lastInLastGroup;
+    @Nullable
     byte[] continuation;
 
     public AggregateCursor(@Nonnull RecordCursor<QueryResult> inner,
                            @Nonnull final StreamGrouping<M> streamGrouping,
                            boolean isCreateDefaultOnEmpty,
-                           byte[] continuation) {
+                           @Nullable byte[] continuation) {
         this.inner = inner;
         this.streamGrouping = streamGrouping;
         this.isCreateDefaultOnEmpty = isCreateDefaultOnEmpty;