Skip to content

Commit 04960e2

Browse files
committed
add signature to TypedVisitor
1 parent 1740682 commit 04960e2

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/query/visitors/BaseVisitor.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -441,6 +441,7 @@ public LogicalOperator visitStatementBody(final RelationalParser.StatementBodyCo
441441
return ddlVisitor.visitStatementBody(ctx);
442442
}
443443

444+
@Nonnull
444445
@Override
445446
public Identifier visitUserDefinedScalarFunctionStatementBody(@Nonnull RelationalParser.UserDefinedScalarFunctionStatementBodyContext ctx) {
446447
return identifierVisitor.visitFullId(ctx.fullId());

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/query/visitors/DelegatingVisitor.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
package com.apple.foundationdb.relational.recordlayer.query.visitors;
2222

2323
import com.apple.foundationdb.annotation.API;
24+
import com.apple.foundationdb.record.query.plan.cascades.UserDefinedFunction;
2425
import com.apple.foundationdb.record.query.plan.cascades.predicates.CompatibleTypeEvolutionPredicate;
2526
import com.apple.foundationdb.record.util.pair.NonnullPair;
2627
import com.apple.foundationdb.relational.api.metadata.DataType;
@@ -264,7 +265,7 @@ public CompilableSqlFunction visitTempSqlInvokedFunction(final RelationalParser.
264265
}
265266

266267
@Override
267-
public com.apple.foundationdb.record.query.plan.cascades.UserDefinedFunction visitSqlInvokedFunction(@Nonnull RelationalParser.SqlInvokedFunctionContext ctx) {
268+
public UserDefinedFunction visitSqlInvokedFunction(@Nonnull RelationalParser.SqlInvokedFunctionContext ctx) {
268269
return getDelegate().visitSqlInvokedFunction(ctx);
269270
}
270271

@@ -876,7 +877,7 @@ public Identifier visitFullId(@Nonnull RelationalParser.FullIdContext ctx) {
876877
@Nonnull
877878
@Override
878879
public Identifier visitUserDefinedScalarFunctionStatementBody(@Nonnull RelationalParser.UserDefinedScalarFunctionStatementBodyContext ctx) {
879-
return (Identifier)getDelegate().visitUserDefinedScalarFunctionStatementBody(ctx);
880+
return getDelegate().visitUserDefinedScalarFunctionStatementBody(ctx);
880881
}
881882

882883
@Nonnull
@@ -1217,7 +1218,7 @@ public Object visitUserDefinedScalarFunctionName(@Nonnull RelationalParser.UserD
12171218

12181219
@Nonnull
12191220
@Override
1220-
public Object visitUserDefinedScalarFunctionCall(@Nonnull RelationalParser.UserDefinedScalarFunctionCallContext ctx) {
1221+
public Expression visitUserDefinedScalarFunctionCall(@Nonnull RelationalParser.UserDefinedScalarFunctionCallContext ctx) {
12211222
return getDelegate().visitUserDefinedScalarFunctionCall(ctx);
12221223
}
12231224

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/query/visitors/TypedVisitor.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,10 @@ public interface TypedVisitor extends RelationalParserVisitor<Object> {
189189
@Override
190190
UserDefinedFunction visitSqlInvokedFunction(RelationalParser.SqlInvokedFunctionContext ctx);
191191

192+
@Nonnull
193+
@Override
194+
Identifier visitUserDefinedScalarFunctionStatementBody(@Nonnull RelationalParser.UserDefinedScalarFunctionStatementBodyContext ctx);
195+
192196
@Override
193197
LogicalOperator visitStatementBody(RelationalParser.StatementBodyContext ctx);
194198

@@ -760,6 +764,10 @@ public interface TypedVisitor extends RelationalParserVisitor<Object> {
760764
@Override
761765
Expression visitAggregateFunctionCall(@Nonnull RelationalParser.AggregateFunctionCallContext ctx);
762766

767+
@Nonnull
768+
@Override
769+
Expression visitUserDefinedScalarFunctionCall(@Nonnull RelationalParser.UserDefinedScalarFunctionCallContext ctx);
770+
763771
@Nonnull
764772
@Override
765773
Object visitSpecificFunctionCall(@Nonnull RelationalParser.SpecificFunctionCallContext ctx);

0 commit comments

Comments
 (0)