Skip to content

Commit 117884b

Browse files
committed
add report link mentioning new ms code coverage
1 parent a655c05 commit 117884b

File tree

3 files changed

+35
-17
lines changed

3 files changed

+35
-17
lines changed

SharedProject/Core/MsTestPlatform/CodeCoverage/MsCodeCoverageRunSettingsService.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,11 @@ public void Initialize(string appDataFolder, IFCCEngine fccEngine, CancellationT
123123
public async Task<MsCodeCoverageCollectionStatus> IsCollectingAsync(ITestOperation testOperation)
124124
{
125125
await InitializeIsCollectingAsync(testOperation);
126-
127-
if (runMsCodeCoverage != RunMsCodeCoverage.No)
126+
if( runMsCodeCoverage == RunMsCodeCoverage.No)
127+
{
128+
reportGeneratorUtil.LogCoverageProcess($"See option {nameof(IAppOptions.RunMsCodeCoverage)} for a better ( Beta ) experience. View readme.");
129+
}
130+
else
128131
{
129132
await TrySetUpForCollectionAsync(testOperation.SolutionDirectory);
130133
}

SharedProject/Core/ReportGenerator/ReportGeneratorUtil.cs

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1389,32 +1389,41 @@ function addCoverageLogElements(){{
13891389
coverageLogContainer.appendChild(coverageLogElement);
13901390
container.appendChild(coverageLogContainer);
13911391
}}
1392-
function addLogMessageElement(message){{
1393-
var logElement = document.createElement('div');
1394-
var fccOutputPanePart = 'FCC Output Pane';
1395-
var fccOutputPaneStartIndex = message.indexOf(fccOutputPanePart);
1396-
if(fccOutputPaneStartIndex != -1){{
1397-
if(fccOutputPaneStartIndex != 0){{
1398-
var before = message.substring(0,fccOutputPaneStartIndex);
1392+
function addExternalMessage(logElement,message,matchLinkPart, externalFn){{
1393+
var matched = false;
1394+
var startIndex = message.indexOf(matchLinkPart);
1395+
if(startIndex != -1){{
1396+
matched = true;
1397+
if(startIndex != 0){{
1398+
var before = message.substring(0,startIndex);
13991399
var beforeEl = document.createElement('span');
14001400
beforeEl.innerText = before;
14011401
logElement.appendChild(beforeEl);
14021402
}}
1403-
var openFccPanelLink = document.createElement('a');
1404-
openFccPanelLink.innerText = fccOutputPanePart;
1405-
openFccPanelLink.href = '#';
1406-
openFccPanelLink.onclick = function(){{
1407-
window.external.{nameof(ScriptManager.ShowFCCOutputPane)}();
1403+
var externalLink = document.createElement('a');
1404+
externalLink.innerText = matchLinkPart;
1405+
externalLink.href = '#';
1406+
externalLink.onclick = function(){{
1407+
window.external[externalFn]();
14081408
return false;
14091409
}}
1410-
logElement.appendChild(openFccPanelLink);
1411-
var after = message.substring(fccOutputPaneStartIndex + fccOutputPanePart.length);
1410+
logElement.appendChild(externalLink);
1411+
var after = message.substring(startIndex + matchLinkPart.length);
14121412
if(after != ''){{
14131413
var afterEl = document.createElement('span');
14141414
afterEl.innerText = after;
14151415
logElement.appendChild(afterEl);
14161416
}}
1417-
}}else{{
1417+
}}
1418+
return matched;
1419+
}}
1420+
function addLogMessageElement(message){{
1421+
var logElement = document.createElement('div');
1422+
var matched = addExternalMessage(logElement,message,'FCC Output Pane','{nameof(ScriptManager.ShowFCCOutputPane)}');
1423+
if(!matched){{
1424+
matched = addExternalMessage(logElement,message,'View readme','{nameof(ScriptManager.ReadReadMe)}');
1425+
}}
1426+
if(!matched){{
14181427
logElement.innerText = message;
14191428
}}
14201429

SharedProject/Output/ScriptManager.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ public class ScriptManager : IScriptManager
2525
internal const string payPal = "https://paypal.me/FortuneNgwenya";
2626
internal const string githubIssues = "https://github.com/FortuneN/FineCodeCoverage/issues";
2727
internal const string marketPlaceRateAndReview = "https://marketplace.visualstudio.com/items?itemName=FortuneNgwenya.FineCodeCoverage&ssr=false#review-details";
28+
internal const string githubReadme = "https://github.com/FortuneN/FineCodeCoverage/blob/master/README.md";
2829
private readonly ISourceFileOpener sourceFileOpener;
2930
private readonly IProcess process;
3031
private readonly IEventAggregator eventAggregator;
@@ -45,6 +46,11 @@ public void OpenFile(string assemblyName, string qualifiedClassName, int file, i
4546
openFileTask = sourceFileOpener.OpenFileAsync(assemblyName, qualifiedClassName, file, line);
4647
}
4748

49+
public void ReadReadMe()
50+
{
51+
process.Start(githubReadme);
52+
}
53+
4854
public void BuyMeACoffee()
4955
{
5056
process.Start(payPal);

0 commit comments

Comments
 (0)