You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Fork the repo of the module that you wish to commit to.
87
87
* Create a Branch, we use [topic branches](https://git-scm.com/book/en/v2/Git-Branching-Branching-Workflows#Topic-Branches) for our commits.
88
88
* Push your commit(s) to your repository.
89
-
* Create a pull request to the original repo in Apache Spot organization.
89
+
* Create a pull request to the original repo in Apache Spot organization.*(See Below for Merging details)*
90
90
91
91
### **Commit Guidelines**
92
92
93
93
* Bug fixes should be a single commit.
94
94
* Please be clear with the commit messages about what you are fixing or adding to the code base. If you code is addressing an open issue please add the reference to the issue in the comments with: Fix: Issue's URL.
95
95
96
96
97
-
### **Merge approval**
97
+
### **Merge Process**
98
98
99
-
Apache Spot maintainers use +1 in a comment on the code review to indicate acceptance,
100
-
at least 3 "+1" from maintainers are required to approve the merge. If you have any question or concern please feel free to add a comment in your pull request or branch and tag any of the maintainers.
99
+
Thanks for considering to contribute to the Spot Project. In order to help make the process a little eaiser for everyone, please follow these steps.
100
+
1) In order to start the merge process please open a ticket in the [Spot Jira](https://issues.apache.org/jira/projects/SPOT/issues) and take note of the Issue key *(SPOT-###)*.
101
+
2) Next, open a Pull-Request (PR) and reference the Issue key in the title of the PR. If you have any question or concern please feel free to add a comment in your pull request or branch and tag any of the maintainers.
102
+
3) Now, it's time for the community to provide feedback on your commit. Getting community feedback can be hard, but start by sending a message to the Dev list; and make sure you're [subscribed](mailto:[email protected]) to the Dev List.
103
+
4) At the same time, maintainers will be taking a look at your PR. The more community input you can get, in the form of comments rather than +1s, the more attention maintainers will give.
104
+
There are is a manual and an automatic merge process
105
+
***Manual:** When a Project maintainer has given a '+1' in the comments, then you're PR has been accepted. However, it must be manually merged by a maintainer at this point.
106
+
***Automatic:** This process initiates when 3 maintainers provide a '+1'
107
+
***Note:** if there are any merge conflicts you will have to come back and fix them before the process can continue.
0 commit comments