Skip to content

Commit 6700185

Browse files
author
Tadd Wood
committed
Merge branch 'master' into pr-142
2 parents 76034f4 + 546139f commit 6700185

File tree

5 files changed

+18
-14
lines changed

5 files changed

+18
-14
lines changed

Diff for: README.md

+13-6
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ Apache Spot functionality is divided into different modules, go to each module f
7171

7272
Our Central repository for our Apache Spot solution is found here. If you find a bug, have question or something to discuss please contact us:
7373

74-
* [Create an Issue](https://issues.apache.org/jira/browse/SPOT-20?jql=project%20%3D%20SPOT).
75-
* [Go to our Slack channel](https://apachespot.slack.com/messages/general/).
74+
* [Create an Issue](https://issues.apache.org/jira/browse/SPOT-20?jql=project%20%3D%20SPOT)
75+
* [Join the Dev List](mailto:[email protected]) and then [send us a message](mailto:[email protected])
7676

7777
## **Contributing to Apache Spot**
7878

@@ -86,18 +86,25 @@ and join our community.
8686
* Fork the repo of the module that you wish to commit to.
8787
* Create a Branch, we use [topic branches](https://git-scm.com/book/en/v2/Git-Branching-Branching-Workflows#Topic-Branches) for our commits.
8888
* Push your commit(s) to your repository.
89-
* Create a pull request to the original repo in Apache Spot organization.
89+
* Create a pull request to the original repo in Apache Spot organization. *(See Below for Merging details)*
9090

9191
### **Commit Guidelines**
9292

9393
* Bug fixes should be a single commit.
9494
* Please be clear with the commit messages about what you are fixing or adding to the code base. If you code is addressing an open issue please add the reference to the issue in the comments with: Fix: Issue's URL.
9595

9696

97-
### **Merge approval**
97+
### **Merge Process**
9898

99-
Apache Spot maintainers use +1 in a comment on the code review to indicate acceptance,
100-
at least 3 "+1" from maintainers are required to approve the merge. If you have any question or concern please feel free to add a comment in your pull request or branch and tag any of the maintainers.
99+
Thanks for considering to contribute to the Spot Project. In order to help make the process a little eaiser for everyone, please follow these steps.
100+
1) In order to start the merge process please open a ticket in the [Spot Jira](https://issues.apache.org/jira/projects/SPOT/issues) and take note of the Issue key *(SPOT-###)*.
101+
2) Next, open a Pull-Request (PR) and reference the Issue key in the title of the PR. If you have any question or concern please feel free to add a comment in your pull request or branch and tag any of the maintainers.
102+
3) Now, it's time for the community to provide feedback on your commit. Getting community feedback can be hard, but start by sending a message to the Dev list; and make sure you're [subscribed](mailto:[email protected]) to the Dev List.
103+
4) At the same time, maintainers will be taking a look at your PR. The more community input you can get, in the form of comments rather than +1s, the more attention maintainers will give.
104+
There are is a manual and an automatic merge process
105+
* **Manual:** When a Project maintainer has given a '+1' in the comments, then you're PR has been accepted. However, it must be manually merged by a maintainer at this point.
106+
* **Automatic:** This process initiates when 3 maintainers provide a '+1'
107+
* **Note:** if there are any merge conflicts you will have to come back and fix them before the process can continue.
101108

102109

103110
## **Licensing**

Diff for: [email protected]

Whitespace-only changes.

Diff for: spot-ingest/start_ingest_standalone.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ fi
5858

5959
INGEST_DATE=`date +"%H_%M_%S"`
6060

61-
screen -d -m -S SPOT-INGEST-${INGEST_CONF}-${INGEST_DATE} -s /bin/bash
61+
screen -d -m -S SPOT-INGEST-${INGEST_CONF}-${INGEST_DATE} -s `which bash`
6262
screen -S SPOT-INGEST-${INGEST_CONF}-${INGEST_DATE} -X setenv TZ ${TIME_ZONE}
6363
screen -dr SPOT-INGEST-${INGEST_CONF}-${INGEST_DATE} -X screen -t Master sh -c "python master_collector.py -t ${INGEST_CONF} -w ${WORKERS_NUM} -id SPOT-INGEST-${INGEST_CONF}-${INGEST_DATE}; echo 'Closing Master...'; sleep 432000"
6464

Diff for: spot-ml/build.sbt

+3-6
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ scalaVersion := "2.11.8"
2323

2424
val sparkVersion = "2.1.0"
2525

26-
import sbtassembly.Plugin.AssemblyKeys._
27-
28-
assemblySettings
26+
baseAssemblySettings
2927

3028
libraryDependencies += "org.apache.spark" %% "spark-core" % sparkVersion % "provided"
3129
libraryDependencies += "org.apache.spark" %% "spark-mllib" % sparkVersion
@@ -37,7 +35,7 @@ resolvers += Resolver.sonatypeRepo("public")
3735

3836
val meta = """META.INF(.)*""".r
3937

40-
mergeStrategy in assembly <<= (mergeStrategy in assembly) { (old) => {
38+
assemblyMergeStrategy in assembly := {
4139
case PathList("org", "apache", "commons", xs@_*) => MergeStrategy.last
4240
case PathList("com", "esotericsoftware", "minlog", xs@_*) => MergeStrategy.last
4341
case PathList("com", "google", xs@_*) => MergeStrategy.last
@@ -50,7 +48,6 @@ mergeStrategy in assembly <<= (mergeStrategy in assembly) { (old) => {
5048
case meta(_) => MergeStrategy.discard
5149
case x => MergeStrategy.first
5250
}
53-
}
5451

5552
// super important with multiple tests running spark Contexts
5653
parallelExecution in Test := false
@@ -69,4 +66,4 @@ getTop1MFileFromAlexa := {
6966
}
7067
}
7168

72-
resourceGenerators in Compile <+= getTop1MFileFromAlexa
69+
resourceGenerators in Compile += getTop1MFileFromAlexa

Diff for: spot-ml/project/plugins.sbt

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@
1515
* limitations under the License.
1616
*/
1717

18-
addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.9.1")
18+
addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.6")

0 commit comments

Comments
 (0)