Skip to content

Not defined in master branch/v1.2 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Roger-luo opened this issue Apr 16, 2019 · 5 comments
Closed

Not defined in master branch/v1.2 #7

Roger-luo opened this issue Apr 16, 2019 · 5 comments

Comments

@Roger-luo
Copy link
Contributor

https://github.com/MikeInnes/IRTools.jl/blob/c39410793a9b79cb5ff6e486df0ffff56d2adcb2/src/reflection/reflection.jl#L23

I guess this is changed due to JuliaLang/julia#31191 ?
@Roger-luo Roger-luo changed the title Not defined in master branch Not defined in master branch/v1.2 Apr 17, 2019
@Roger-luo Roger-luo mentioned this issue Apr 23, 2019
Closed
@tpapp
Copy link

tpapp commented Apr 23, 2019

I think that Core.Compiler.specialize_method should be a drop-in replacement for code_for_method.

@MikeInnes
Copy link
Member

Any chance of trying it in a PR? Would be great to add Julia nightly to travis testing as well.

@tpapp
Copy link

tpapp commented Apr 23, 2019

Sure, will do one in a few minutes.

@tpapp
Copy link

tpapp commented Apr 23, 2019

I take that back: apparently the changes were more complex than this (omitting world age, other small changes to the reflection API) so I think this should be done someone who knows these better.

@MikeInnes
Copy link
Member

Ok, fixed on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tpapp @MikeInnes @Roger-luo