-
-
Notifications
You must be signed in to change notification settings - Fork 170
Add new option parse_animation
to parse metadata for animated images
#676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 96.60% 96.49% -0.11%
==========================================
Files 24 24
Lines 883 914 +31
==========================================
+ Hits 853 882 +29
- Misses 30 32 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8c3f16c
to
c126a82
Compare
packages/core/lib/generators/integrations/image_integration.dart
Outdated
Show resolved
Hide resolved
packages/core/lib/generators/integrations/image_integration.dart
Outdated
Show resolved
Hide resolved
Also the workflow is complaining about untracked changes |
Co-authored-by: Alex Li <[email protected]>
Co-authored-by: Alex Li <[email protected]>
Co-authored-by: Alex Li <[email protected]>
1382b0f
to
010cae8
Compare
All issues and comments should have been addressed or replied. Please take a look at these changes. Thanks. |
# Conflicts: # packages/core/lib/generators/integrations/image_integration.dart # packages/core/lib/generators/integrations/svg_integration.dart # packages/core/test_resources/actual_data/assets_assets_camel_case.gen.dart # packages/core/test_resources/actual_data/assets_assets_change_class_name.gen.dart # packages/core/test_resources/actual_data/assets_assets_directory_path.gen.dart # packages/core/test_resources/actual_data/assets_assets_directory_path_with_package_parameter.gen.dart # packages/core/test_resources/actual_data/assets_assets_exclude_files.gen.dart # packages/core/test_resources/actual_data/assets_assets_flavored.gen.dart # packages/core/test_resources/actual_data/assets_assets_no_integrations.gen.dart # packages/core/test_resources/actual_data/assets_assets_package_parameter.gen.dart # packages/core/test_resources/actual_data/assets_assets_package_parameter_disable_null_safety.gen.dart # packages/core/test_resources/actual_data/assets_assets_parse_metadata.gen.dart # packages/core/test_resources/actual_data/assets_assets_snake_case.gen.dart # packages/core/test_resources/actual_data/assets_change_output_path.gen.dart # packages/core/test_resources/actual_data/assets_normal.gen.dart # packages/core/test_resources/actual_data/assets_only_flutter_value.gen.dart # packages/core/test_resources/actual_data/assets_wrong_output_path.gen.dart
## 5.11.0 **Feature** - [#576](#576) Add support for deferred components. by [@ianmaciel](https://github.com/ianmaciel) - [#676](#676) Add new option `parse_animation` to parse metadata for animated images. by [@huandu](https://github.com/huandu) - [#680](#680) Add svg `ColorMapper` to svg loader. by [@AlexV525](https://github.com/AlexV525) - [#685](#685) Use `.vec` SVG class for `vector_graphics_compiler` transformed assets. by [@Albert221](https://github.com/Albert221) - [#697](#697) Refactor how generated files are being formatted. by [@AlexV525](https://github.com/AlexV525) **Development** - [#681](#682) Bump `dart_style` v3 which also requires Dart 3.4. by [@AlexV525](https://github.com/AlexV525) - [#682](#682) Add Facts generate utils. by [@AlexV525](https://github.com/AlexV525) - [#694](#694) Use fine-grained logger instead of `stdout.writeln`. by [@AlexV525](https://github.com/AlexV525) - [#698](#698) Improve workflow with automatic formatting. by [@AlexV525](https://github.com/AlexV525) - [#699](#699) Allow `build 3.0.0`. by [@davidmorgan](https://github.com/davidmorgan)
What does this change?
Fixes #675
Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run test
)melos run format
to automatically apply formatting)