Skip to content

Add new option parse_animation to parse metadata for animated images #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 17, 2025

Conversation

huandu
Copy link
Contributor

@huandu huandu commented Mar 24, 2025

What does this change?

Fixes #675

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.49%. Comparing base (63abef6) to head (f9958e7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lib/generators/integrations/image_integration.dart 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
- Coverage   96.60%   96.49%   -0.11%     
==========================================
  Files          24       24              
  Lines         883      914      +31     
==========================================
+ Hits          853      882      +29     
- Misses         30       32       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huandu huandu force-pushed the feature/parse-animation branch from 8c3f16c to c126a82 Compare April 7, 2025 03:10
@AlexV525
Copy link
Member

Also the workflow is complaining about untracked changes

@huandu huandu force-pushed the feature/parse-animation branch from 1382b0f to 010cae8 Compare April 16, 2025 03:41
@huandu
Copy link
Contributor Author

huandu commented Apr 16, 2025

All issues and comments should have been addressed or replied. Please take a look at these changes. Thanks.

huandu and others added 7 commits April 16, 2025 20:33
# Conflicts:
#	packages/core/lib/generators/integrations/image_integration.dart
#	packages/core/lib/generators/integrations/svg_integration.dart
#	packages/core/test_resources/actual_data/assets_assets_camel_case.gen.dart
#	packages/core/test_resources/actual_data/assets_assets_change_class_name.gen.dart
#	packages/core/test_resources/actual_data/assets_assets_directory_path.gen.dart
#	packages/core/test_resources/actual_data/assets_assets_directory_path_with_package_parameter.gen.dart
#	packages/core/test_resources/actual_data/assets_assets_exclude_files.gen.dart
#	packages/core/test_resources/actual_data/assets_assets_flavored.gen.dart
#	packages/core/test_resources/actual_data/assets_assets_no_integrations.gen.dart
#	packages/core/test_resources/actual_data/assets_assets_package_parameter.gen.dart
#	packages/core/test_resources/actual_data/assets_assets_package_parameter_disable_null_safety.gen.dart
#	packages/core/test_resources/actual_data/assets_assets_parse_metadata.gen.dart
#	packages/core/test_resources/actual_data/assets_assets_snake_case.gen.dart
#	packages/core/test_resources/actual_data/assets_change_output_path.gen.dart
#	packages/core/test_resources/actual_data/assets_normal.gen.dart
#	packages/core/test_resources/actual_data/assets_only_flutter_value.gen.dart
#	packages/core/test_resources/actual_data/assets_wrong_output_path.gen.dart
@AlexV525 AlexV525 merged commit d252f15 into FlutterGen:main Jul 17, 2025
4 of 5 checks passed
@AlexV525 AlexV525 mentioned this pull request Jul 17, 2025
AlexV525 added a commit that referenced this pull request Jul 17, 2025
## 5.11.0

**Feature**

- [#576](#576) Add support
for deferred components. by [@ianmaciel](https://github.com/ianmaciel)
- [#676](#676) Add new
option `parse_animation` to parse metadata for animated images. by
[@huandu](https://github.com/huandu)
- [#680](#680) Add svg
`ColorMapper` to svg loader. by [@AlexV525](https://github.com/AlexV525)
- [#685](#685) Use `.vec`
SVG class for `vector_graphics_compiler` transformed assets. by
[@Albert221](https://github.com/Albert221)
- [#697](#697) Refactor
how generated files are being formatted. by
[@AlexV525](https://github.com/AlexV525)

**Development**

- [#681](#682) Bump
`dart_style` v3 which also requires Dart 3.4. by
[@AlexV525](https://github.com/AlexV525)
- [#682](#682) Add Facts
generate utils. by [@AlexV525](https://github.com/AlexV525)
- [#694](#694) Use
fine-grained logger instead of `stdout.writeln`. by
[@AlexV525](https://github.com/AlexV525)
- [#698](#698) Improve
workflow with automatic formatting. by
[@AlexV525](https://github.com/AlexV525)
- [#699](#699) Allow
`build 3.0.0`. by [@davidmorgan](https://github.com/davidmorgan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Parse meta data for images with animation
2 participants