lints (hoc081098#35)

* lints

* lints

* lints

Author: hoc081098

analysis_options.yaml

@@ -1,4 +1,4 @@
-include: package:pedantic/analysis_options.1.11.0.yaml
+include: package:flutter_lints/flutter.yaml
 analyzer:
   exclude:
     # Ignore generated files
@@ -9,4 +9,9 @@ linter:
   rules:
     - public_member_api_docs
     - prefer_final_locals
-    - prefer_relative_imports
+    - prefer_relative_imports
+    # https://github.com/dart-lang/lints#migrating-from-packagepedantic
+    - always_declare_return_types
+    - prefer_single_quotes
+    - unawaited_futures
+    - unsafe_html

example/pubspec.lock

@@ -7,7 +7,7 @@ packages:
       name: async
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.5.0"
+    version: "2.8.1"
   boolean_selector:
     dependency: transitive
     description:
@@ -28,7 +28,7 @@ packages:
       name: charcode
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.2.0"
+    version: "1.3.1"
   clock:
     dependency: transitive
     description:
@@ -120,7 +120,7 @@ packages:
       name: meta
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.3.0"
+    version: "1.7.0"
   path:
     dependency: transitive
     description:
@@ -183,35 +183,35 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "2.1.0"
+    version: "2.2.0"
   rx_storage:
     dependency: transitive
     description:
       name: rx_storage
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.1.0"
+    version: "1.2.0"
   rxdart:
     dependency: transitive
     description:
       name: rxdart
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.27.0"
+    version: "0.27.2"
   rxdart_ext:
     dependency: transitive
     description:
       name: rxdart_ext
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.1.0"
+    version: "0.1.2"
   shared_preferences:
     dependency: transitive
     description:
       name: shared_preferences
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.5"
+    version: "2.0.7"
   shared_preferences_linux:
     dependency: transitive
     description:
@@ -258,7 +258,7 @@ packages:
       name: source_span
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.8.0"
+    version: "1.8.1"
   stack_trace:
     dependency: transitive
     description:
@@ -293,7 +293,7 @@ packages:
       name: test_api
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.2.19"
+    version: "0.4.2"
   typed_data:
     dependency: transitive
     description:
@@ -324,4 +324,4 @@ packages:
     version: "0.2.0"
 sdks:
   dart: ">=2.12.0 <3.0.0"
-  flutter: ">=1.20.0"
+  flutter: ">=2.0.0"

lib/src/config/global_config.dart

@@ -1,3 +1,5 @@
+import 'package:flutter/foundation.dart';
+
 import '../logger/default_logger.dart';
 import '../logger/logger.dart';
 
@@ -7,5 +9,5 @@ class RxSharedPreferencesConfigs {
   /// Default value is a [RxSharedPreferencesDefaultLogger].
   /// Can be set to `null` to disable logging.
   static RxSharedPreferencesLogger? logger =
-      const RxSharedPreferencesDefaultLogger();
+      kReleaseMode ? null : const RxSharedPreferencesDefaultLogger();
 }

lib/src/logger/default_logger.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 import 'package:rx_storage/rx_storage.dart';
 
 import '../../rx_shared_preferences.dart';

pubspec.lock

@@ -7,7 +7,7 @@ packages:
       name: async
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.5.0"
+    version: "2.8.1"
   boolean_selector:
     dependency: transitive
     description:
@@ -28,7 +28,7 @@ packages:
       name: charcode
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.2.0"
+    version: "1.3.1"
   clock:
     dependency: transitive
     description:
@@ -76,6 +76,13 @@ packages:
     description: flutter
     source: sdk
     version: "0.0.0"
+  flutter_lints:
+    dependency: "direct dev"
+    description:
+      name: flutter_lints
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.4"
   flutter_test:
     dependency: "direct dev"
     description: flutter
@@ -93,6 +100,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "0.6.3"
+  lints:
+    dependency: transitive
+    description:
+      name: lints
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.1"
   matcher:
     dependency: transitive
     description:
@@ -106,7 +120,7 @@ packages:
       name: meta
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.3.0"
+    version: "1.7.0"
   path:
     dependency: transitive
     description:
@@ -135,13 +149,6 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "2.0.0"
-  pedantic:
-    dependency: "direct dev"
-    description:
-      name: pedantic
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "1.11.0"
   platform:
     dependency: transitive
     description:
@@ -169,28 +176,28 @@ packages:
       name: rx_storage
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.1.0"
+    version: "1.2.0"
   rxdart:
     dependency: transitive
     description:
       name: rxdart
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.27.0"
+    version: "0.27.2"
   rxdart_ext:
     dependency: transitive
     description:
       name: rxdart_ext
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.1.0"
+    version: "0.1.2"
   shared_preferences:
     dependency: "direct main"
     description:
       name: shared_preferences
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.5"
+    version: "2.0.7"
   shared_preferences_linux:
     dependency: transitive
     description:
@@ -237,7 +244,7 @@ packages:
       name: source_span
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.8.0"
+    version: "1.8.1"
   stack_trace:
     dependency: transitive
     description:
@@ -272,7 +279,7 @@ packages:
       name: test_api
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.2.19"
+    version: "0.4.2"
   typed_data:
     dependency: transitive
     description:
@@ -303,4 +310,4 @@ packages:
     version: "0.2.0"
 sdks:
   dart: ">=2.12.0 <3.0.0"
-  flutter: ">=1.20.0"
+  flutter: ">=2.0.0"

pubspec.yaml

@@ -7,6 +7,7 @@ issue_tracker: https://github.com/hoc081098/rx_shared_preferences/issues
 
 environment:
   sdk: '>=2.12.0 <3.0.0'
+  flutter: '>=2.0.0 <3.0.0'
 
 dependencies:
   flutter:
@@ -18,6 +19,6 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
-  pedantic: ^1.11.0
+  flutter_lints: ^1.0.4
   shared_preferences_platform_interface: ^2.0.0
   collection: ^1.15.0

test/adapter_test.dart

@@ -135,8 +135,8 @@ void main() {
         (e, s) => expect(e, isA<StateError>()),
       );
 
-      store.failedMethod = MethodCall('setValue');
-      [
+      store.failedMethod = const MethodCall('setValue');
+      for (final f in [
         adapter.setString('String', kTestValues2['flutter.String'] as String),
         adapter.setBool('bool', kTestValues2['flutter.bool'] as bool),
         adapter.setInt('int', kTestValues2['flutter.int'] as int),
@@ -148,7 +148,9 @@ void main() {
           user2,
           (u) => jsonEncode(u),
         ),
-      ].forEach((f) => expect(f, throwsPlatformException));
+      ]) {
+        expect(f, throwsPlatformException);
+      }
     });
 
     test('removing', () async {
@@ -170,7 +172,7 @@ void main() {
             growable: true,
           ));
 
-      store.failedMethod = MethodCall('remove');
+      store.failedMethod = const MethodCall('remove');
       expect(adapter.remove(key), throwsPlatformException);
     });
 
@@ -192,7 +194,7 @@ void main() {
       expect(await adapter.getStringList('List'), null);
       expect(store.log, <Matcher>[isMethodCall('clear', arguments: null)]);
 
-      store.failedMethod = MethodCall('clear');
+      store.failedMethod = const MethodCall('clear');
       expect(adapter.clear(), throwsPlatformException);
     });
 
@@ -209,7 +211,7 @@ void main() {
 
       SharedPreferencesStorePlatform.instance =
           store = FakeSharedPreferencesStore(kTestValues2)
-            ..failedMethod = MethodCall('getAll');
+            ..failedMethod = const MethodCall('getAll');
       expect(adapter.reload(), throwsPlatformException);
     });
 
@@ -235,7 +237,7 @@ void main() {
       );
 
       expect(
-        SetEquality<String>().equals(keys, expected),
+        const SetEquality<String>().equals(keys, expected),
         isTrue,
       );
     });

test/fake_shared_prefs_store.dart

@@ -44,7 +44,7 @@ class FakeSharedPreferencesStore implements SharedPreferencesStorePlatform {
     if (failedMethod?.method == 'clear') {
       return Future.value(false);
     }
-    log.add(MethodCall('clear'));
+    log.add(const MethodCall('clear'));
     return backend.clear();
   }
 
@@ -55,7 +55,7 @@ class FakeSharedPreferencesStore implements SharedPreferencesStorePlatform {
         PlatformException(code: 'error', message: 'Cannot getAll'),
       );
     }
-    log.add(MethodCall('getAll'));
+    log.add(const MethodCall('getAll'));
     return backend.getAll();
   }