Merge pull request github#19430 from github/fix-for-translations

Fallback if translated file cannot be found

Author: sarahs

middleware/contextualizers/generic-toc.js

@@ -8,7 +8,8 @@ module.exports = async function genericToc (req, res, next) {
   const currentSiteTree = req.context.siteTree[req.context.currentLanguage][req.context.currentVersion]
 
   // Find the array of child pages that start with the requested path.
-  const currentPageInSiteTree = findPageInSiteTree(currentSiteTree.childPages, req.context.currentPath)
+  const currentPageInSiteTree = findPageInSiteTree(currentSiteTree.childPages, req.context.currentPath, req.context.currentLanguage)
+  if (!currentPageInSiteTree) return next()
 
   req.context.tocItems = sortBy(
     await getUnsortedTocItems(currentPageInSiteTree.childPages, req.context),
@@ -21,13 +22,22 @@ module.exports = async function genericToc (req, res, next) {
 
 // Recursively loop through the siteTree until we reach the point where the
 // current siteTree page is the same as the requested page. Then stop.
-function findPageInSiteTree (pageArray, currentPath) {
+function findPageInSiteTree (pageArray, currentPath, currentLanguage) {
   const childPage = pageArray.find(page => {
     // Find a page that matches at least an initial part of the current path
     const regex = new RegExp(`^${page.href}($|/)`, 'm')
     return regex.test(currentPath)
   })
 
+  // Fallback for outdated translations
+  if (!childPage && currentLanguage !== 'en') {
+    return findPageInSiteTree(pageArray, currentPath.replace(`/${currentLanguage}`, '/en'), 'en')
+  }
+
+  if (!childPage && currentLanguage === 'en') {
+    return
+  }
+
   if (childPage.href === currentPath) {
     return childPage
   }