Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove topic from Broker Schema #5295

Open
joepavitt opened this issue Mar 11, 2025 · 4 comments
Open

Remove topic from Broker Schema #5295

joepavitt opened this issue Mar 11, 2025 · 4 comments
Assignees
Labels
area:frontend For any issues that require work in the frontend/UI feature-request New feature or request that needs to be turned into Epic/Story details size:S - 2 Sizing estimation point
Milestone

Comments

@joepavitt
Copy link
Contributor

Description

Provide an option on a given topic in the hierarchy to "remove" it, as some users will test the broker first, before committing to a formal schema.

API should already be in place

Which customers would this be available to

Team + Enterprise Tiers (EE)

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@joepavitt joepavitt added area:frontend For any issues that require work in the frontend/UI feature-request New feature or request that needs to be turned into Epic/Story details size:S - 2 Sizing estimation point labels Mar 11, 2025
@joepavitt joepavitt added this to the 2.15 milestone Mar 11, 2025
@joepavitt joepavitt moved this to Up Next in 🛠 Development Mar 11, 2025
@joepavitt joepavitt changed the title Remove topic from schema Remove topic from Broker Schema Mar 11, 2025
@hardillb
Copy link
Contributor

  • DELETE /api/v1/teams/:teamId/brokers/:brokerId/topics/:topicId

Should allow for the deleting of an individual topic and it's metadata

@Steve-Mcl Steve-Mcl moved this from Up Next to In Design in 🛠 Development Mar 11, 2025
@joepavitt
Copy link
Contributor Author

@Steve-Mcl any reason this is in-design, and not in-progress?

@Steve-Mcl Steve-Mcl moved this from In Design to In Progress in 🛠 Development Mar 12, 2025
@Steve-Mcl
Copy link
Contributor

@joepavitt my bad. I put it in design when looking at requirements then forgot to update status when i started work. (updated the status now that it is 80% complete 🤦)

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Mar 12, 2025

@joepavitt there were some pain points implementing this that would make reasonable follow ups

  1. The organisation of the components (as in where the topic decoration occurs) made implementation difficult (the bare topic data is decorated in a sub component, but the topics are retrieved in the parent component meaning not so pretty workarounds had to be employed when handling updates/deletions)
  2. The topic hierarchy API does NOT return the newly created object (or the update object) meaning we have to do a 2nd API call and re-request all topics (due to how we decorate the bare topics).
    3. In short, the API should return the newly created resource (or at minimum add a Location Header to permit a single request)

@Steve-Mcl Steve-Mcl moved this from In Progress to Review in 🛠 Development Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI feature-request New feature or request that needs to be turned into Epic/Story details size:S - 2 Sizing estimation point
Projects
Status: No status
Status: Review
Development

No branches or pull requests

3 participants