Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split & shift the "Protect Instance" setting for an Instance #5283

Open
joepavitt opened this issue Mar 10, 2025 · 0 comments
Open

Split & shift the "Protect Instance" setting for an Instance #5283

joepavitt opened this issue Mar 10, 2025 · 0 comments
Labels
size:M - 3 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Milestone

Comments

@joepavitt
Copy link
Contributor

Description

We have 3 states that the NR Editor can be configured to run in:

  • Open: Access for view/edit as "normal"
  • Protected: View-only mode whereby the Node-RED Editor allows viewers of the flows, but no "Deploy" actions.
  • Disabled: The Editor cannot be accessed at all, by anybody

The complexity here is that the "Disabled" state still allows writing of flows via a Pipeline by anybody. The "Protected" mode only enables Team Owners to push Pipeline stages to this instance.

A point of friction here too is that the setting to set "Protected" mode is in a different tab to that of the "Disabled" option. We should unify these options under the "Editor" tab,

Current State

Editor Settings

Image

Protect Mode

Image

Proposal

A new "Editor Access" option within the "Editor" tab. These then provides a dropdown for three options:

  • Available
  • View-Only
  • Disabled

A new "Read/Write Permissions" option within the Editor tab, which is available when "Editor Access" is "View-Only" that provides the following options:

  • Disabled - No changes can be pushed to this Instance at all
  • Pipelines Only (Team Owner) - Changes can be pushed via Pipelines if you are a Team Owner
  • Pipelines Only (Team Owners + Members) - Changes can be pushed via Pipelines if you are a Team Owner or Team Member

Availability in Tiers

It's worth noting here that the current "Protected Mode" is an Enterprise-only feature, so the current "Protected" option would not show at other tiers. I'm not sure (at the time of writing) how tied together the view-only and team-only write access for Pipelines is, so may need to modify this slightly when implementing

Epic/Story

No response

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@joepavitt joepavitt added area:frontend For any issues that require work in the frontend/UI size:XS - 1 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story. labels Mar 10, 2025
@joepavitt joepavitt added this to the 2.16 milestone Mar 10, 2025
@joepavitt joepavitt added size:M - 3 Sizing estimation point and removed area:frontend For any issues that require work in the frontend/UI size:XS - 1 Sizing estimation point labels Mar 10, 2025
@joepavitt joepavitt changed the title Move the “Protect Instance” option and clean the settings Split & shift the "Protect Instance" setting for an Instance Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M - 3 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
Status: No status
Status: No status
Development

No branches or pull requests

1 participant