Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nr-theme files removed after installing module from palette #356

Closed
felix-reck opened this issue Feb 28, 2025 · 2 comments · Fixed by #358
Closed

nr-theme files removed after installing module from palette #356

felix-reck opened this issue Feb 28, 2025 · 2 comments · Fixed by #358
Assignees
Labels
bug Something isn't working
Milestone

Comments

@felix-reck
Copy link

Current Behavior

When installing a module from the palette, files from @flowfuse/nr-theme are removed from the filesystem. (However, the theme is still visible in the palette manager under installed nodes)
This causes Node-RED to fall back to the default theme.
Restarting the device-agent service restores the files.

Image

Not a critical problem, just something I've been noticing for some time.

Expected Behavior

@flowfuse/nr-theme should not be removed from filesystem.

Steps To Reproduce

  • Install device agent (e.g., using raspbian-install-device-agent.sh)
  • Open the Node-RED editor and install a module from palette, e.g., @flowfuse/node-red-dashboad
  • Refresh the browser
  • The default Node-RED theme is loaded instead of FlowFuse-Theme
  • Error appears in the device logs

Environment

  • FlowFuse version: FlowFuse Cloud
  • Node.js version: v18.20.4 & v20.11.1
  • npm version: 10.7.0 & 10.9.0
  • Platform/OS: Linux RHEL 8.10, Windows Server 2019, Raspberry Pi OS (bookworm)
  • Browser: MS Edge, Firefox

Linked Customers

No response

@felix-reck felix-reck added the needs-triage Needs looking at to decide what to do label Feb 28, 2025
@knolleary
Copy link
Member

@felix-reck thanks for reporting - that is odd. Will investigate.

@knolleary
Copy link
Member

sorry - accidental click of the wrong button... we will investigate 😉

@knolleary knolleary added bug Something isn't working and removed needs-triage Needs looking at to decide what to do labels Feb 28, 2025
@knolleary knolleary self-assigned this Feb 28, 2025
@knolleary knolleary moved this to Review in 🛠 Development Feb 28, 2025
@knolleary knolleary added this to the 2.15 milestone Mar 5, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in 🛠 Development Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Closed / Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants