Reduce GlobalStore accounts in addition to sessionStorage removal (#5849)

martgil · web-flow · commit d70bf0f2f845 · 2024-10-10T11:28:31.000+03:00
* Reduce GlobalStore accounts in addition to sessionStorage removal

* use better variable names

* pr reviews: apply corrections
diff --git a/extension/js/common/settings.ts b/extension/js/common/settings.ts
@@ -88,6 +88,7 @@ export class Settings {
     if (!acctEmails.includes(acctEmail)) {
       throw new Error(`"${acctEmail}" is not a known account_email in "${JSON.stringify(acctEmails)}"`);
     }
+    await GlobalStore.acctEmailsRemove(acctEmail);
     const storageIndexesToRemove: AccountIndex[] = [];
     const filter = AbstractStore.singleScopeRawIndex(acctEmail, '');
     if (!filter) {
@@ -190,7 +191,6 @@ export class Settings {
       }
     }
     await Settings.acctStorageReset(oldAcctEmail);
-    await GlobalStore.acctEmailsRemove(oldAcctEmail);
   }
 
   public static async renderPrvCompatFixUiAndWaitTilSubmittedByUser(

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,7 @@ export class Settings {`
`88`	`88`	`if (!acctEmails.includes(acctEmail)) {`
`89`	`89`	throw new Error(`"${acctEmail}" is not a known account_email in "${JSON.stringify(acctEmails)}"`);
`90`	`90`	`}`
	`91`	`+ await GlobalStore.acctEmailsRemove(acctEmail);`
`91`	`92`	`const storageIndexesToRemove: AccountIndex[] = [];`
`92`	`93`	`const filter = AbstractStore.singleScopeRawIndex(acctEmail, '');`
`93`	`94`	`if (!filter) {`
`@@ -190,7 +191,6 @@ export class Settings {`
`190`	`191`	`}`
`191`	`192`	`}`
`192`	`193`	`await Settings.acctStorageReset(oldAcctEmail);`
`193`		`- await GlobalStore.acctEmailsRemove(oldAcctEmail);`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`public static async renderPrvCompatFixUiAndWaitTilSubmittedByUser(`