Skip to content

Commit a56a913

Browse files
authored
fix: null이슈 해결 (#129)
1 parent a354e5b commit a56a913

File tree

5 files changed

+20
-14
lines changed

5 files changed

+20
-14
lines changed

src/main/java/com/flint/flint/mail/service/RateLimitService.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,13 @@ public class RateLimitService {
1919
private final RedisUtil redisUtil;
2020

2121
public Boolean checkAPICall(Long key) {
22-
String apiCall = String.valueOf(redisUtil.findAPICallByKey(key));
22+
Object apiCall = redisUtil.findAPICallByKey(key);
23+
2324
if (apiCall == null) { //한 번도 호출 안 한 경우
24-
redisUtil.saveAPICall(key, String.valueOf((int)1), Expiration);
25+
redisUtil.saveAPICall(key, String.valueOf(1), Expiration);
2526
return true;
26-
} else if (Integer.parseInt(apiCall) < MAX_API_CALL) { //10 번 미만 호출 한 경우
27-
redisUtil.updateAPICall(key, String.valueOf(Integer.parseInt(apiCall) + 1));
27+
} else if (Integer.parseInt((String) apiCall) < MAX_API_CALL) { //10 번 미만 호출 한 경우
28+
redisUtil.updateAPICall(key, String.valueOf(Integer.parseInt((String) apiCall) + 1));
2829
return true;
2930
}
3031
return false; //10 번인 경우

src/main/java/com/flint/flint/member/domain/main/Member.java

+1
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public class Member extends BaseTimeEntity {
5353
private String providerName;
5454

5555
@NotNull
56+
@Column(unique = true)
5657
private String providerId;
5758

5859
@Builder

src/main/java/com/flint/flint/security/auth/AuthenticationController.java

-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ public class AuthenticationController {
2727
public ResponseForm<AuthenticationResponse> register(@Valid @RequestBody RegisterRequest registerRequest, HttpServletRequest oauth2TokenWithBearer) {
2828
AuthenticationResponse authenticationResponse = authenticationService.register(registerRequest, oauth2TokenWithBearer);
2929
return new ResponseForm<>(authenticationResponse);
30-
3130
}
3231

3332
@PostMapping("/login/{providerName}")

src/main/java/com/flint/flint/security/oauth/KakaoOAuth2UserAttribute.java

+10-6
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
/**
1515
* 카카오에서 받아오는 사용자 정보 담는 DTO
16+
*
1617
* @Author 정순원
1718
* @Since 2023-08-19
1819
*/
@@ -32,18 +33,20 @@ public Member toEntity() {
3233

3334
return Member.builder()
3435
.providerName(KAKAO_PROVIDER_ID)
35-
.providerId(KAKAO_PROVIDER_ID+" "+getProviderId())//띄어쓰기 포함
36+
.providerId(getProviderId())//띄어쓰기 포함
3637
.email(getEmail())
3738
.name(getName())
3839
.gender(Gender.valueOf(getGender().toUpperCase())) //대소문자 구별하니 바꿔줘야 함
39-
.authority(Authority.AUTHUSER)
40+
.authority(Authority.UNAUTHUSER)
4041
.birthday(getBirthday())
4142
.build();
4243
}
4344

4445
//TODO
4546
@Override
46-
public String getProviderId() { return "kakao " + this.id;}
47+
public String getProviderId() {
48+
return KAKAO_PROVIDER_ID + "_" + this.id;
49+
}
4750

4851
@Override
4952
public String getEmail() {
@@ -66,17 +69,18 @@ public String getBirthday() {
6669
}
6770

6871
@Override
69-
public void setUserAttributesByOauthToken(String authorizionRequestHeader) {
72+
public void setUserAttributesByOauthToken(String kakaoAccessToken) {
7073

7174

7275
JSONObject response = WebClient.create()
7376
.get()
7477
.uri("https://kapi.kakao.com/v2/user/me")
75-
.headers(httpHeaders -> httpHeaders.setBearerAuth(authorizionRequestHeader))
78+
.headers(httpHeaders -> httpHeaders.setBearerAuth(kakaoAccessToken))
7679
.retrieve()
7780
.bodyToMono(JSONObject.class)
7881
.block();
82+
7983
this.id = response.get("id").toString();
80-
this.kakaoAccount = (Map<String, Object>)response.get("kakao_account");
84+
this.kakaoAccount = (Map<String, Object>) response.get("kakao_account");
8185
}
8286
}

src/main/java/com/flint/flint/security/oauth/NaverOAuth2UserAttribute.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
/**
1515
* 네이버에서 받아오는 사용자 정보 담는 DTO
16+
*
1617
* @Author 정순원
1718
* @Since 2023-08-19
1819
*/
@@ -30,11 +31,11 @@ public class NaverOAuth2UserAttribute extends OAuth2UserAttribute {
3031
public Member toEntity() {
3132
return Member.builder()
3233
.providerName(NAVER_PROVIDER_ID)
33-
.providerId(NAVER_PROVIDER_ID + " " + getProviderId())
34+
.providerId(getProviderId())
3435
.email(getEmail())
3536
.name(getName())
3637
.gender(Gender.valueOf(getGender().toUpperCase())) //대소문자 구별하니 바꿔줘야 함
37-
.authority(Authority.AUTHUSER)
38+
.authority(Authority.UNAUTHUSER)
3839
.birthday(getBirthday())
3940
.build();
4041
}
@@ -75,6 +76,6 @@ public void setUserAttributesByOauthToken(String authorizionRequestHeader) {
7576
.retrieve()
7677
.bodyToMono(JSONObject.class)
7778
.block();
78-
this.response = (Map<String, Object>)naverResponse.get("response");
79+
this.response = (Map<String, Object>) naverResponse.get("response");
7980
}
8081
}

0 commit comments

Comments
 (0)