-
Notifications
You must be signed in to change notification settings - Fork 500
Open
Description
Summary
The change requests documentation states:
"Click Approve or Deny to record your decision."
However, there is no deny/reject functionality implemented anywhere in the product — neither in the frontend UI nor the backend API.
Current behaviour
- The frontend only renders an Approve button on change request pages (
ChangeRequestDetailPage.tsx) - The backend
ChangeRequestmodel only has anapprove()method — nodeny()orreject() - The
ChangeRequestApprovalmodel only tracksapproved_at— no rejected/denied state - Audit log constants only cover created, approved, committed, and deleted — no denial event
Expected behaviour
Either:
- Fix the docs — remove the reference to "Deny" to match the actual product, or
- Implement the feature — add deny/reject functionality to change requests
Steps to reproduce
- Open the change requests documentation page
- Note the mention of a "Deny" button
- Create a change request and navigate to it as a reviewer
- Observe there is no "Deny" option
Reported by
A customer in Slack raised this as they couldn't find the deny option described in the docs.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels