-
Notifications
You must be signed in to change notification settings - Fork 501
Editing an approved Change Request does not invalidate approval #7056
Copy link
Copy link
Open
Description
How are you running Flagsmith
- Self Hosted with Docker
- Self Hosted with Kubernetes
- SaaS at flagsmith.com
- Some other way (add details in description below)
Describe the bug
When a change request has been approved the creator can edit the change request and still publish it without re-requesting approval. Editing an approved change request should invalidate the existing approval and require re-approval before publishing.
Steps To Reproduce
- Create a change request
- Have a colleague approve it
- Edit the change request after approval
- Observe that the Publish action is still available without re-approval
- Publishing succeeds despite the post-approval edit
Expected behavior
Editing an approved change request should invalidate the approval, requiring the change request to be re-approved before it can be published.
Screenshots
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels