Skip to content

Editing an approved Change Request does not invalidate approval #7056

@adamvialpando

Description

@adamvialpando

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

When a change request has been approved the creator can edit the change request and still publish it without re-requesting approval. Editing an approved change request should invalidate the existing approval and require re-approval before publishing.

Steps To Reproduce

  1. Create a change request
  2. Have a colleague approve it
  3. Edit the change request after approval
  4. Observe that the Publish action is still available without re-approval
  5. Publishing succeeds despite the post-approval edit

Expected behavior

Editing an approved change request should invalidate the approval, requiring the change request to be re-approved before it can be published.

Screenshots

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions