Skip to content

Commit 4ed42a8

Browse files
committed
ci: fix rustfmt job rules
Specifically, fe8bc3f made the "default" case `manual` instead of `never`, which is causing all staging pipelines to have that job regardless of any file `changes`, and always `manual` making it block pipelines. Let's make it automatic for upstream pipelines (ie. staging and push-to-main), and only run on file `changes`. Fixes: fe8bc3f ("ci: Only run rustfmt when necessary") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36260> (cherry picked from commit f065c2f)
1 parent bfe5d10 commit 4ed42a8

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.gitlab-ci/test-source-dep.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,9 @@
228228
- if: *is-merge-request
229229
when: never
230230
# non-pre-merge: run but only advisory
231+
- if: $CI_PROJECT_NAMESPACE == "mesa"
232+
changes: *rustfmt_files
233+
allow_failure: true
231234
- when: manual
232235
allow_failure: true
233236

.pick_status.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,7 @@
694694
"description": "ci: fix rustfmt job rules",
695695
"nominated": true,
696696
"nomination_type": 2,
697-
"resolution": 0,
697+
"resolution": 1,
698698
"main_sha": null,
699699
"because_sha": "fe8bc3f23e3bc01ff7af90ad3b25aef410fd51ad",
700700
"notes": null

0 commit comments

Comments
 (0)