-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider adding support for the TCP framing method used by the 1.0 OSC spec #17
Comments
I think I've made this work - although I don't seem to be able to do a pull request (see https://github.com/richardwilliamson/F53OSC-RW for my working version - changes are in F53OSCClient, F53OSCParser and F53OSCSocket) I did a couple of other tweaks as well |
Cool! Hm, having a pull request for comparison helps a lot to hone in on the specific changes. Does this page help set one up? https://help.github.com/articles/creating-a-pull-request-from-a-fork/ |
think that's done - I took most of the code from the old commit before 1.0 support was dropped, however for some reason that used 64 bit integers for the size, where they seem to need to be 32 bit, so I changed that. It seems to work fine for me when talking to an eos, I haven't done a great deal of testing though |
@balord created branch 17-tcp-osc-1.0-framing for handling TCP non-SLIP framing (OSC 1.0). Full disclosure — that branch is untested and might not be something we decide to merge. It should be considered experimental for now. |
In the comments of #3, @richardwilliamson notes:
The OSC 1.0 spec recommended using a size-count-preamble to send OSC messages over TCP.
It might be nice to allow specifying this as an option.
The text was updated successfully, but these errors were encountered: