Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite player icon using config option #35

Open
mariuszste opened this issue May 9, 2023 · 3 comments
Open

Overwrite player icon using config option #35

mariuszste opened this issue May 9, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mariuszste
Copy link

mariuszste commented May 9, 2023

Since discord can accept any valid image URL as the icon for rich presence it would be nice to be able to overwrite that for any player. This is especially useful for new players that don't have an icon built in.

things to consider: how would this interact with #32
Discord actually has 2 slots for icons, so maybe we can put the player icon in the small circle one and the album over in the big one?

@FichteFoll FichteFoll added the enhancement New feature or request label May 9, 2023
@FichteFoll
Copy link
Owner

Yes, it's a good idea to implement this together with #32.

@FichteFoll
Copy link
Owner

FichteFoll commented May 9, 2023

This is possible now via the client_id (de9d532) and icon (dbeed4f) configuration options. This does support HTTP URLs already, which I actually forgot to document, so I'm considering this to be done for the next release (whenever I get around to packaging that because I changed a few things that I'll need to test first and would also like to implement a few more things until then).

FichteFoll added a commit that referenced this issue May 9, 2023
@FichteFoll FichteFoll added this to the 0.4.0 milestone May 9, 2023
@mariuszste
Copy link
Author

Awesome, thanks. Moving more things to the config is definitely welcome.

@FichteFoll FichteFoll self-assigned this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants