Merge pull request magento#1235 from makzef/1215-number-fromat-exception-empty-string

1215: fix parsing of plugin sort order value

Author: VitaliyBoyko

src/com/magento/idea/magento2plugin/stubs/indexes/PluginIndex.java

@@ -94,19 +94,33 @@ private Set<PluginData> getPluginsForType(final XmlTag typeNode) {
 
                 for (final XmlTag pluginTag: typeNode.findSubTags(ModuleDiXml.PLUGIN_TAG_NAME)) {
                     final String pluginType = pluginTag.getAttributeValue(ModuleDiXml.TYPE_ATTR);
-                    String pluginSortOrder = pluginTag.getAttributeValue(ModuleDiXml.SORT_ORDER_ATTR);
+                    final String pluginSortOrder = pluginTag.getAttributeValue(ModuleDiXml.SORT_ORDER_ATTR);
 
                     if (pluginType != null) {
-                        pluginSortOrder = pluginSortOrder == null ? "0" : pluginSortOrder;
-                        final PluginData pluginData = getPluginDataObject(pluginType,  Integer.parseInt(pluginSortOrder));
+                        final PluginData pluginData = getPluginDataObject(pluginType, getIntegerOrZeroValue(pluginSortOrder));
                         results.add(pluginData);
                     }
                 }
 
                 return results;
             }
 
-            private PluginData getPluginDataObject(final String pluginType, final Integer sortOrder) {
+            private Integer getIntegerOrZeroValue(final String sortOrder) {
+                if (sortOrder == null || sortOrder.isEmpty()) {
+                    return 0;
+                }
+
+                try {
+                    return Integer.parseInt(sortOrder);
+                } catch (NumberFormatException e) {
+                    return 0;
+                }
+            }
+
+            private PluginData getPluginDataObject(
+                    final String pluginType,
+                    final Integer sortOrder
+            ) {
                 return new PluginData(pluginType,  sortOrder);
             }
         };