Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readonly types in AsyncStorage Typescript break this package #47

Open
djMax opened this issue Feb 10, 2022 · 1 comment
Open

readonly types in AsyncStorage Typescript break this package #47

djMax opened this issue Feb 10, 2022 · 1 comment

Comments

@djMax
Copy link

djMax commented Feb 10, 2022

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Typescript error as referenced in #46

Here is the diff that solved my problem:

diff --git a/node_modules/rn-async-storage-flipper/index.d.ts b/node_modules/rn-async-storage-flipper/index.d.ts
index 704da6a..08d7117 100644
--- a/node_modules/rn-async-storage-flipper/index.d.ts
+++ b/node_modules/rn-async-storage-flipper/index.d.ts
@@ -1,10 +1,10 @@
 interface Storage {
-    getAllKeys(callback?: (error?: Error, keys?: string[]) => void): Promise<string[]>;
+    getAllKeys(callback?: (error?: Error | null, keys?: readonly string[] | null) => void): Promise<readonly string[]>;
 
     multiGet(
         keys: string[],
-        callback?: (errors?: Error[], result?: [string, string | null][]) => void
-    ): Promise<[string, string | null][]>;
+        callback?: (errors: readonly (Error | null)[] | null | undefined, result?: readonly [string, string | null][]) => void
+    ): Promise<void | readonly [string, string | null][]>;
 }
 
 export default function RNAsyncStorageFlipper(_storage: Storage): void;

This issue body was partially generated by patch-package.

@ghost
Copy link

ghost commented May 26, 2022

I'm facing the same thing while using async storage 1.17.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant