Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/Work around Jackson 3.0 Module->JacksonModule renaming #499

Closed
cowtowncoder opened this issue Feb 4, 2021 · 4 comments
Closed

Rename/Work around Jackson 3.0 Module->JacksonModule renaming #499

cowtowncoder opened this issue Feb 4, 2021 · 4 comments
Assignees

Comments

@cowtowncoder
Copy link
Member

I did this:

FasterXML/jackson-databind#3037

for Jackson 3.0 (master) but did not realize that name JacksonModule was in use in Scala module.
The reason to get out of Module name is due to addition of java.lang.Module, and seems reasonable. I hope Scala module can work around this problem either via imports or (if that makes more sense) renaming its JacksonModule into something else.

@pjfanning
Copy link
Member

@cowtowncoder I've committed a workaround

@cowtowncoder
Copy link
Member Author

cowtowncoder commented Feb 4, 2021

Thank you!

There will be more renamings but I will try to tackle them if I can.

One next step is removal of (deprecated already in 3.0) of Contextual[De]Serializer interface.

But I also really need to create a wiki doc outlining various renamings: there will be many, but they should be documented to make updates (and possible having scripts to automate) easier.

@pjfanning
Copy link
Member

pjfanning commented Feb 4, 2021

@cowtowncoder Contextual[De]Serializer is still used a lot in jackson-module-scala - what is the alternative code?

update - looks like the interfaces can just be removed as they are no longer needed - I have committed some changes

@cowtowncoder
Copy link
Member Author

@pjfanning Interfaces were merged into JsonSerializer / JsonDeserializer (with no-op implementation). Same is true for Resolvable[De]Serializer, likewise removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants